X-Git-Url: http://git.droids-corp.org/?a=blobdiff_plain;f=devtools%2Fcheck-git-log.sh;h=f9d0550393b9f19312ec76f94221dedbb5ec993c;hb=bf6eb2c22fd1944e8d892eee09bc0d24622bf377;hp=c601f6ae9901a96d08f501bc8fa96bafa5dbce1c;hpb=cb9c546f9058ab8600d9cd24085ad348193a4a9d;p=dpdk.git diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index c601f6ae99..f9d0550393 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -1,34 +1,6 @@ #! /bin/sh - -# BSD LICENSE -# +# SPDX-License-Identifier: BSD-3-Clause # Copyright 2016 6WIND S.A. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: -# -# * Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# * Redistributions in binary form must reproduce the above copyright -# notice, this list of conditions and the following disclaimer in -# the documentation and/or other materials provided with the -# distribution. -# * Neither the name of 6WIND S.A. nor the names of its -# contributors may be used to endorse or promote products derived -# from this software without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # Check commit logs (headlines and references) # @@ -106,8 +78,8 @@ bad=$(echo "$headlines" | grep --color=always \ # check headline lowercase for first words bad=$(echo "$headlines" | grep --color=always \ - -e '^.*[A-Z].*:' \ - -e ': *[A-Z]' \ + -e '^.*[[:upper:]].*:' \ + -e ': *[[:upper:]]' \ | sed 's,^,\t,') [ -z "$bad" ] || printf "Wrong headline uppercase:\n$bad\n" @@ -118,28 +90,42 @@ bad=$(echo "$headlines" | grep -E --color=always \ -e ':.*\<[hsf]w\>' \ -e ':.*\' \ -e ':.*\' \ - -e ':.*\' \ - -e ':.*\' \ - -e ':.*\' \ + -e ':.*\' \ + -e ':.*\<(Aarch64|AArch64|AARCH64|Aarch32|AArch32|AARCH32)\>' \ + -e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \ + -e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \ -e ':.*\' \ + -e ':.*\' \ -e ':.*\' \ + -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ + -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ + -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ + -e ':.*\' \ -e ':.*\' \ + -e ':.*\' \ -e ':.*\' \ -e ':.*\' \ + -e ':.*\' \ + -e ':.*\' \ -e ':.*\' \ + -e ':.*\' \ + -e ':.*\' \ -e ':.*\<[Vv]lan\>' \ + -e ':.*\' \ -e ':.*\' \ + | grep \ + -v ':.*\' \ | sed 's,^,\t,') [ -z "$bad" ] || printf "Wrong headline lowercase:\n$bad\n" @@ -175,6 +161,24 @@ bad=$(echo "$tags" | sed 's,^.,\t&,') [ -z "$bad" ] || printf "Wrong tag:\n$bad\n" +# check missing Coverity issue: tag +bad=$(for commit in $commits; do + body=$(git log --format='%b' -1 $commit) + echo "$body" | grep -qi coverity || continue + echo "$body" | grep -q '^Coverity issue:' && continue + git log --format='\t%s' -1 $commit +done) +[ -z "$bad" ] || printf "Missing 'Coverity issue:' tag:\n$bad\n" + +# check missing Bugzilla ID: tag +bad=$(for commit in $commits; do + body=$(git log --format='%b' -1 $commit) + echo "$body" | grep -qi bugzilla || continue + echo "$body" | grep -q '^Bugzilla ID:' && continue + git log --format='\t%s' -1 $commit +done) +[ -z "$bad" ] || printf "Missing 'Bugzilla ID:' tag:\n$bad\n" + # check missing Fixes: tag bad=$(for fix in $fixes ; do git log --format='%b' -1 $fix | grep -q '^Fixes: ' ||