X-Git-Url: http://git.droids-corp.org/?a=blobdiff_plain;f=lib%2Fecoli_node_str.c;h=0100fecf26a07867df94ef01b4d8d39326f2ff8e;hb=ea3c5a3c8510621f5b30c2cc11bbc12ac2eff1bb;hp=fe8c7bb55419766d81ef52fffe85df7e5804c3ba;hpb=90d09f5806b457e758ac7f4fadf485d24162d38f;p=protos%2Flibecoli.git

diff --git a/lib/ecoli_node_str.c b/lib/ecoli_node_str.c
index fe8c7bb..0100fec 100644
--- a/lib/ecoli_node_str.c
+++ b/lib/ecoli_node_str.c
@@ -1,28 +1,5 @@
-/*
- * Copyright (c) 2016, Olivier MATZ <zer0@droids-corp.org>
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in the
- *       documentation and/or other materials provided with the distribution.
- *     * Neither the name of the University of California, Berkeley nor the
- *       names of its contributors may be used to endorse or promote products
- *       derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL THE REGENTS AND CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2016, Olivier MATZ <zer0@droids-corp.org>
  */
 
 #include <stdio.h>
@@ -35,63 +12,55 @@
 #include <ecoli_test.h>
 #include <ecoli_strvec.h>
 #include <ecoli_node.h>
-#include <ecoli_parsed.h>
-#include <ecoli_completed.h>
+#include <ecoli_config.h>
+#include <ecoli_parse.h>
+#include <ecoli_complete.h>
 #include <ecoli_node_str.h>
 
+EC_LOG_TYPE_REGISTER(node_str);
+
 struct ec_node_str {
 	struct ec_node gen;
 	char *string;
 	unsigned len;
 };
 
-static struct ec_parsed *ec_node_str_parse(const struct ec_node *gen_node,
-	const struct ec_strvec *strvec)
+static int
+ec_node_str_parse(const struct ec_node *gen_node,
+		struct ec_parse *state,
+		const struct ec_strvec *strvec)
 {
 	struct ec_node_str *node = (struct ec_node_str *)gen_node;
-	struct ec_strvec *match_strvec;
-	struct ec_parsed *parsed = NULL;
 	const char *str;
 
-	parsed = ec_parsed();
-	if (parsed == NULL)
-		goto fail;
+	(void)state;
+
+	if (node->string == NULL) {
+		errno = EINVAL;
+		return -1;
+	}
 
 	if (ec_strvec_len(strvec) == 0)
-		return parsed;
+		return EC_PARSE_NOMATCH;
 
 	str = ec_strvec_val(strvec, 0);
 	if (strcmp(str, node->string) != 0)
-		return parsed;
-
-	match_strvec = ec_strvec_ndup(strvec, 0, 1);
-	if (match_strvec == NULL)
-		goto fail;
+		return EC_PARSE_NOMATCH;
 
-	ec_parsed_set_match(parsed, gen_node, match_strvec);
-
-	return parsed;
-
- fail:
-	ec_parsed_free(parsed);
-	return NULL;
+	return 1;
 }
 
-static struct ec_completed *ec_node_str_complete(const struct ec_node *gen_node,
-	const struct ec_strvec *strvec)
+static int
+ec_node_str_complete(const struct ec_node *gen_node,
+		struct ec_comp *comp,
+		const struct ec_strvec *strvec)
 {
 	struct ec_node_str *node = (struct ec_node_str *)gen_node;
-	struct ec_completed *completed;
-	struct ec_completed_elt *completed_elt;
-	const char *str, *add;
+	const char *str;
 	size_t n = 0;
 
-	completed = ec_completed();
-	if (completed == NULL)
-		return NULL;
-
 	if (ec_strvec_len(strvec) != 1)
-		return completed;
+		return 0;
 
 	str = ec_strvec_val(strvec, 0);
 	for (n = 0; n < node->len; n++) {
@@ -99,20 +68,15 @@ static struct ec_completed *ec_node_str_complete(const struct ec_node *gen_node,
 			break;
 	}
 
+	/* no completion */
 	if (str[n] != '\0')
-		add = NULL;
-	else
-		add = node->string + n;
-
-	completed_elt = ec_completed_elt(gen_node, add);
-	if (completed_elt == NULL) {
-		ec_completed_free(completed);
-		return NULL;
-	}
+		return EC_PARSE_NOMATCH;
 
-	ec_completed_add_elt(completed, completed_elt);
+	if (ec_comp_add_item(comp, gen_node, NULL, EC_COMP_FULL,
+					str, node->string) < 0)
+		return -1;
 
-	return completed;
+	return 0;
 }
 
 static const char *ec_node_str_desc(const struct ec_node *gen_node)
@@ -129,8 +93,47 @@ static void ec_node_str_free_priv(struct ec_node *gen_node)
 	ec_free(node->string);
 }
 
+static const struct ec_config_schema ec_node_str_schema[] = {
+	{
+		.key = "string",
+		.desc = "The string to match.",
+		.type = EC_CONFIG_TYPE_STRING,
+	},
+};
+
+static int ec_node_str_set_config(struct ec_node *gen_node,
+				const struct ec_config *config)
+{
+	struct ec_node_str *node = (struct ec_node_str *)gen_node;
+	const struct ec_config *value = NULL;
+	char *s = NULL;
+
+	value = ec_config_dict_get(config, "string");
+	if (value == NULL) {
+		errno = EINVAL;
+		goto fail;
+	}
+
+	s = ec_strdup(value->string);
+	if (s == NULL)
+		goto fail;
+
+	ec_free(node->string);
+	node->string = s;
+	node->len = strlen(node->string);
+
+	return 0;
+
+fail:
+	ec_free(s);
+	return -1;
+}
+
 static struct ec_node_type ec_node_str_type = {
 	.name = "str",
+	.schema = ec_node_str_schema,
+	.schema_len = EC_COUNT_OF(ec_node_str_schema),
+	.set_config = ec_node_str_set_config,
 	.parse = ec_node_str_parse,
 	.complete = ec_node_str_complete,
 	.desc = ec_node_str_desc,
@@ -142,20 +145,35 @@ EC_NODE_TYPE_REGISTER(ec_node_str_type);
 
 int ec_node_str_set_str(struct ec_node *gen_node, const char *str)
 {
-	struct ec_node_str *node = (struct ec_node_str *)gen_node;
+	struct ec_config *config = NULL;
+	int ret;
+
+	if (ec_node_check_type(gen_node, &ec_node_str_type) < 0)
+		goto fail;
+
+	if (str == NULL) {
+		errno = EINVAL;
+		goto fail;
+	}
 
-	if (str == NULL)
-		return -EINVAL;
-	if (node->string != NULL)
-		return -EEXIST; // XXX allow to replace
+	config = ec_config_dict();
+	if (config == NULL)
+		goto fail;
 
-	node->string = ec_strdup(str);
-	if (node->string == NULL)
-		return -ENOMEM;
+	ret = ec_config_dict_set(config, "string", ec_config_string(str));
+	if (ret < 0)
+		goto fail;
 
-	node->len = strlen(node->string);
+	ret = ec_node_set_config(gen_node, config);
+	config = NULL;
+	if (ret < 0)
+		goto fail;
 
 	return 0;
+
+fail:
+	ec_config_free(config);
+	return -1;
 }
 
 struct ec_node *ec_node_str(const char *id, const char *str)
@@ -176,77 +194,75 @@ fail:
 	return NULL;
 }
 
+/* LCOV_EXCL_START */
 static int ec_node_str_testcase(void)
 {
 	struct ec_node *node;
-	int ret = 0;
+	int testres = 0;
 
-	/* XXX use EC_NO_ID instead of NULL */
-	node = ec_node_str(NULL, "foo");
+	node = ec_node_str(EC_NO_ID, "foo");
 	if (node == NULL) {
-		ec_log(EC_LOG_ERR, "cannot create node\n");
+		EC_LOG(EC_LOG_ERR, "cannot create node\n");
 		return -1;
 	}
-	ret |= EC_TEST_CHECK_PARSE(node, 1, "foo");
-	ret |= EC_TEST_CHECK_PARSE(node, 1, "foo", "bar");
-	ret |= EC_TEST_CHECK_PARSE(node, -1, "foobar");
-	ret |= EC_TEST_CHECK_PARSE(node, -1, " foo");
-	ret |= EC_TEST_CHECK_PARSE(node, -1, "");
+	testres |= EC_TEST_CHECK(!strcmp(ec_node_desc(node), "foo"),
+		"Invalid node description.");
+	testres |= EC_TEST_CHECK_PARSE(node, 1, "foo");
+	testres |= EC_TEST_CHECK_PARSE(node, 1, "foo", "bar");
+	testres |= EC_TEST_CHECK_PARSE(node, -1, "foobar");
+	testres |= EC_TEST_CHECK_PARSE(node, -1, " foo");
+	testres |= EC_TEST_CHECK_PARSE(node, -1, "");
 	ec_node_free(node);
 
-	node = ec_node_str(NULL, "Здравствуйте");
+	node = ec_node_str(EC_NO_ID, "Здравствуйте");
 	if (node == NULL) {
-		ec_log(EC_LOG_ERR, "cannot create node\n");
+		EC_LOG(EC_LOG_ERR, "cannot create node\n");
 		return -1;
 	}
-	ret |= EC_TEST_CHECK_PARSE(node, 1, "Здравствуйте");
-	ret |= EC_TEST_CHECK_PARSE(node, 1, "Здравствуйте",
+	testres |= EC_TEST_CHECK_PARSE(node, 1, "Здравствуйте");
+	testres |= EC_TEST_CHECK_PARSE(node, 1, "Здравствуйте",
 		"John!");
-	ret |= EC_TEST_CHECK_PARSE(node, -1, "foo");
-	ret |= EC_TEST_CHECK_PARSE(node, -1, "");
+	testres |= EC_TEST_CHECK_PARSE(node, -1, "foo");
+	testres |= EC_TEST_CHECK_PARSE(node, -1, "");
 	ec_node_free(node);
 
 	/* an empty string node always matches */
-	node = ec_node_str(NULL, "");
+	node = ec_node_str(EC_NO_ID, "");
 	if (node == NULL) {
-		ec_log(EC_LOG_ERR, "cannot create node\n");
+		EC_LOG(EC_LOG_ERR, "cannot create node\n");
 		return -1;
 	}
-	ret |= EC_TEST_CHECK_PARSE(node, 1, "");
-	ret |= EC_TEST_CHECK_PARSE(node, 1, "", "foo");
-	ret |= EC_TEST_CHECK_PARSE(node, -1, "foo");
+	testres |= EC_TEST_CHECK_PARSE(node, 1, "");
+	testres |= EC_TEST_CHECK_PARSE(node, 1, "", "foo");
+	testres |= EC_TEST_CHECK_PARSE(node, -1, "foo");
 	ec_node_free(node);
 
 	/* test completion */
-	node = ec_node_str(NULL, "foo");
+	node = ec_node_str(EC_NO_ID, "foo");
 	if (node == NULL) {
-		ec_log(EC_LOG_ERR, "cannot create node\n");
+		EC_LOG(EC_LOG_ERR, "cannot create node\n");
 		return -1;
 	}
-	ret |= EC_TEST_CHECK_COMPLETE(node,
-		EC_NODE_ENDLIST,
+	testres |= EC_TEST_CHECK_COMPLETE(node,
 		EC_NODE_ENDLIST,
-		"");
-	ret |= EC_TEST_CHECK_COMPLETE(node,
+		EC_NODE_ENDLIST);
+	testres |= EC_TEST_CHECK_COMPLETE(node,
 		"", EC_NODE_ENDLIST,
-		"foo", EC_NODE_ENDLIST,
-		"foo");
-	ret |= EC_TEST_CHECK_COMPLETE(node,
+		"foo", EC_NODE_ENDLIST);
+	testres |= EC_TEST_CHECK_COMPLETE(node,
 		"f", EC_NODE_ENDLIST,
-		"oo", EC_NODE_ENDLIST,
-		"oo");
-	ret |= EC_TEST_CHECK_COMPLETE(node,
+		"foo", EC_NODE_ENDLIST);
+	testres |= EC_TEST_CHECK_COMPLETE(node,
 		"foo", EC_NODE_ENDLIST,
-		"", EC_NODE_ENDLIST,
-		"");
-	ret |= EC_TEST_CHECK_COMPLETE(node,
+		"foo", EC_NODE_ENDLIST);
+	testres |= EC_TEST_CHECK_COMPLETE(node,
 		"x", EC_NODE_ENDLIST,
-		EC_NODE_ENDLIST,
-		"");
+		EC_NODE_ENDLIST);
 	ec_node_free(node);
 
-	return ret;
+	return testres;
 }
+/* LCOV_EXCL_STOP */
 
 static struct ec_test ec_node_str_test = {
 	.name = "node_str",