From: Alejandro Lucero Date: Mon, 23 Apr 2018 11:23:58 +0000 (+0100) Subject: net/nfp: fix mbufs releasing when stop or close X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=0c0e46c36bcc5dfe9d2aa605e1a5f714d45e0b7f;p=dpdk.git net/nfp: fix mbufs releasing when stop or close PMDs have the responsibility of releasing mbufs sent through xmit burst function. NFP PMD attaches those sent mbufs to the TX ring structure, and it is at the next time a specific ring descriptor is going to be used when the previous linked mbuf, already transmitted at that point, is released. Those mbufs belonging to a chained mbuf got its own link to a ring descriptor, and they are released independently of the mbuf head of that chain. The problem is how those mbufs are released when the PMD is stopped or closed. Instead of releasing those mbufs as the xmit functions does, this is independently of being in a mbuf chain, the code calls rte_pktmbuf_free which will release not just the mbuf head in that chain but all the chained mbufs. The loop will try to release those mbufs which have already been released again when chained mbufs exist. This patch fixes the problem using rte_pktmbuf_free_seg instead. Fixes: b812daadad0d ("nfp: add Rx and Tx") Cc: stable@dpdk.org Signed-off-by: Alejandro Lucero --- diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 2a4b006e06..a5875f2301 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -263,7 +263,7 @@ nfp_net_tx_queue_release_mbufs(struct nfp_net_txq *txq) for (i = 0; i < txq->tx_count; i++) { if (txq->txbufs[i].mbuf) { - rte_pktmbuf_free(txq->txbufs[i].mbuf); + rte_pktmbuf_free_seg(txq->txbufs[i].mbuf); txq->txbufs[i].mbuf = NULL; } }