From: Dekel Peled Date: Wed, 22 Jan 2020 14:27:15 +0000 (+0200) Subject: net/mlx5: fix bit mask to validate push VLAN X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=82e4aca2caa011c85911615dc38e17da86c5a184;hp=a2268a4cfb08e70e3f0f0a082033ad5a24a2a07d;p=dpdk.git net/mlx5: fix bit mask to validate push VLAN Validation function of 'push VLAN' action uses (POP_VLAN or PUSH_VLAN) actions flags, instead of using a mask of both flags. This patch replaces it to use existing VLAN_ACTIONS mask. Fixes: 9aee7a8418d4 ("net/mlx5: support push flow action on VLAN header") Cc: stable@dpdk.org Signed-off-by: Dekel Peled Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index afa3d0e1ce..d7176c80ef 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -1746,8 +1746,7 @@ flow_dv_validate_action_push_vlan(uint64_t action_flags, return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, action, "invalid vlan ethertype"); - if (action_flags & - (MLX5_FLOW_ACTION_OF_POP_VLAN | MLX5_FLOW_ACTION_OF_PUSH_VLAN)) + if (action_flags & MLX5_FLOW_VLAN_ACTIONS) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, action, "no support for multiple VLAN "