From: Bruce Richardson Date: Wed, 19 Sep 2018 10:04:16 +0000 (+0100) Subject: net/avf: fix missing compiler error flags X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=bfd38e4d708bc2479e70329ce242ce2e13c8da5d;p=dpdk.git net/avf: fix missing compiler error flags The AVF driver was missing $(WERROR_FLAGS) in it's cflags, which means that a number of compilation errors were getting missed. This patch adds in the flag and fixes most of the errors, just disabling the strict-aliasing ones. Fixes: 22b123a36d07 ("net/avf: initialize PMD") Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx") Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") CC: stable@dpdk.org Signed-off-by: Bruce Richardson Reviewed-by: Ferruh Yigit --- diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile index 3f815bbc43..0a142c1045 100644 --- a/drivers/net/avf/Makefile +++ b/drivers/net/avf/Makefile @@ -8,7 +8,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # LIB = librte_pmd_avf.a -CFLAGS += -O3 +CFLAGS += -O3 $(WERROR_FLAGS) -Wno-strict-aliasing LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash LDLIBS += -lrte_bus_pci diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index 6b6ff7d557..5494984778 100644 --- a/drivers/net/avf/avf_ethdev.c +++ b/drivers/net/avf/avf_ethdev.c @@ -559,7 +559,7 @@ avf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) } static const uint32_t * -avf_dev_supported_ptypes_get(struct rte_eth_dev *dev) +avf_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused) { static const uint32_t ptypes[] = { RTE_PTYPE_L2_ETHER, diff --git a/drivers/net/avf/avf_rxtx.h b/drivers/net/avf/avf_rxtx.h index 297d0776d4..c4120f8a4e 100644 --- a/drivers/net/avf/avf_rxtx.h +++ b/drivers/net/avf/avf_rxtx.h @@ -227,7 +227,7 @@ static inline void avf_dump_tx_descriptor(const struct avf_tx_queue *txq, const void *desc, uint16_t tx_id) { - char *name; + const char *name; const struct avf_tx_desc *tx_desc = desc; enum avf_tx_desc_dtype_value type; diff --git a/drivers/net/avf/avf_rxtx_vec_sse.c b/drivers/net/avf/avf_rxtx_vec_sse.c index 8275100f37..343a6aac3a 100644 --- a/drivers/net/avf/avf_rxtx_vec_sse.c +++ b/drivers/net/avf/avf_rxtx_vec_sse.c @@ -621,7 +621,7 @@ avf_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts, return nb_pkts; } -void __attribute__((cold)) +static void __attribute__((cold)) avf_rx_queue_release_mbufs_sse(struct avf_rx_queue *rxq) { _avf_rx_queue_release_mbufs_vec(rxq);