From d8e2337ac4e32132e5a26dc351604447b341366d Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Tue, 28 Jan 2014 17:06:41 +0100 Subject: [PATCH] kvargs: add const attribute in handler parameters The "value" argument is read-only and should be const. Signed-off-by: Olivier Matz Acked-by: Bruce Richardson --- lib/librte_kvargs/rte_kvargs.h | 2 +- lib/librte_pmd_pcap/rte_eth_pcap.c | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/librte_kvargs/rte_kvargs.h b/lib/librte_kvargs/rte_kvargs.h index d09dab860b..98b8a7c1ef 100644 --- a/lib/librte_kvargs/rte_kvargs.h +++ b/lib/librte_kvargs/rte_kvargs.h @@ -64,7 +64,7 @@ extern "C" { #define RTE_KVARGS_KV_DELIM "=" /** Type of callback function used by rte_kvargs_process() */ -typedef int (*arg_handler_t)(char *value, void *opaque); +typedef int (*arg_handler_t)(const char *value, void *opaque); /** A key/value association */ struct rte_kvargs_pair { diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pcap.c index c1c9b11905..51a0aa4967 100644 --- a/lib/librte_pmd_pcap/rte_eth_pcap.c +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c @@ -403,10 +403,10 @@ static struct eth_dev_ops ops = { * reference of it for use it later on. */ static int -open_rx_pcap(char *value, void *extra_args) +open_rx_pcap(const char *value, void *extra_args) { unsigned i; - char *pcap_filename = value; + const char *pcap_filename = value; struct rx_pcaps *pcaps = extra_args; pcap_t *rx_pcap; @@ -426,10 +426,10 @@ open_rx_pcap(char *value, void *extra_args) * for use it later on. */ static int -open_tx_pcap(char *value, void *extra_args) +open_tx_pcap(const char *value, void *extra_args) { unsigned i; - char *pcap_filename = value; + const char *pcap_filename = value; struct tx_pcaps *dumpers = extra_args; pcap_t *tx_pcap; pcap_dumper_t *dumper; @@ -476,7 +476,7 @@ open_iface_live(const char *iface, pcap_t **pcap) { * Opens an interface for reading and writing */ static inline int -open_rx_tx_iface(char *value, void *extra_args) +open_rx_tx_iface(const char *value, void *extra_args) { const char *iface = value; pcap_t **pcap = extra_args; @@ -490,7 +490,7 @@ open_rx_tx_iface(char *value, void *extra_args) * Opens a NIC for reading packets from it */ static inline int -open_rx_iface(char *value, void *extra_args) +open_rx_iface(const char *value, void *extra_args) { unsigned i; const char *iface = value; @@ -510,7 +510,7 @@ open_rx_iface(char *value, void *extra_args) * Opens a NIC for writing packets to it */ static inline int -open_tx_iface(char *value, void *extra_args) +open_tx_iface(const char *value, void *extra_args) { unsigned i; const char *iface = value; -- 2.20.1