From 167d9c67975fb2207e03644ce7b5e23d56b73e70 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Tue, 13 Aug 2019 01:03:53 +0200 Subject: [PATCH] build: remove redundant libs from pkgconfig As explained in drivers/meson.build, " For the find_library() case (but not with dependency()) we also need to specify the "-l" flags in pkgconfig_extra_libs variable too, so that it can be reflected in the pkgconfig output for static builds. " The commit e30b4e566f47 ("build: improve dependency handling") must be followed up with this one in order to remove more occurences of pkgconfig_extra_libs redundant with use of dependency(). Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Luca Boccassi --- drivers/compress/isal/meson.build | 1 - drivers/net/af_xdp/meson.build | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/compress/isal/meson.build b/drivers/compress/isal/meson.build index 67b5c4aaec..25578880db 100644 --- a/drivers/compress/isal/meson.build +++ b/drivers/compress/isal/meson.build @@ -10,6 +10,5 @@ endif deps += 'bus_vdev' sources = files('isal_compress_pmd.c', 'isal_compress_pmd_ops.c') ext_deps += dep -pkgconfig_extra_libs += '-lisal' allow_experimental_apis = true diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build index ac679b92bb..307aa0e388 100644 --- a/drivers/net/af_xdp/meson.build +++ b/drivers/net/af_xdp/meson.build @@ -10,7 +10,6 @@ endif if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xdp.h') ext_deps += bpf_dep - pkgconfig_extra_libs += '-lbpf' else build = false reason = 'missing dependency, "libbpf"' -- 2.20.1