From 18f02ff75949de9c2468514b9a805a1cf4591793 Mon Sep 17 00:00:00 2001 From: Daniel Kan Date: Wed, 12 Mar 2014 13:19:59 -0700 Subject: [PATCH] pci: fix igb_uio mapping for virtio_uio and vmxnet3_uio Since commit 10ed994 (pci: use igb_uio mapping only when needed), the flag RTE_PCI_DRV_NEED_IGB_UIO must be set even if RTE_EAL_UNBIND_PORTS is disabled. It was not the case for virtio_uio and vmxnet3_uio so the uio resources were not mapped when RTE_EAL_UNBIND_PORTS was not defined. Specifically, pci_uio_map_resource() was not called so pci_dev->mem_resource was not mapped. Signed-off-by: Daniel Kan Signed-off-by: Thomas Monjalon --- lib/librte_pmd_virtio/virtio_ethdev.c | 2 -- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c index 1cd921b588..f107161ce8 100644 --- a/lib/librte_pmd_virtio/virtio_ethdev.c +++ b/lib/librte_pmd_virtio/virtio_ethdev.c @@ -474,9 +474,7 @@ static struct eth_driver rte_virtio_pmd = { { .name = "rte_virtio_pmd", .id_table = pci_id_virtio_map, -#ifdef RTE_EAL_UNBIND_PORTS .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO, -#endif }, .eth_dev_init = eth_virtio_dev_init, .dev_private_size = sizeof(struct virtio_adapter), diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c index 6757aa27fc..8259cfe7d0 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c @@ -267,9 +267,7 @@ static struct eth_driver rte_vmxnet3_pmd = { { .name = "rte_vmxnet3_pmd", .id_table = pci_id_vmxnet3_map, -#ifdef RTE_EAL_UNBIND_PORTS .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO, -#endif }, .eth_dev_init = eth_vmxnet3_dev_init, .dev_private_size = sizeof(struct vmxnet3_adapter), -- 2.20.1