From 1b897991473fc2fe76a130c527ab0cc93b1ac72a Mon Sep 17 00:00:00 2001 From: Lukasz Krakowiak Date: Thu, 28 Mar 2019 16:55:07 +0100 Subject: [PATCH] power: update error handling Update for handling negative returned status from functions call. Signed-off-by: Lukasz Krakowiak Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_manager.c | 4 ++-- examples/vm_power_manager/channel_monitor.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c index de1a868919..09bfa5c0d3 100644 --- a/examples/vm_power_manager/channel_manager.c +++ b/examples/vm_power_manager/channel_manager.c @@ -224,7 +224,7 @@ open_non_blocking_channel(struct channel_info *info) struct timeval tv; info->fd = socket(AF_UNIX, SOCK_STREAM, 0); - if (info->fd == -1) { + if (info->fd < 0) { RTE_LOG(ERR, CHANNEL_MANAGER, "Error(%s) creating socket for '%s'\n", strerror(errno), info->channel_path); @@ -285,7 +285,7 @@ open_host_channel(struct channel_info *info) int flags; info->fd = open(info->channel_path, O_RDWR | O_RSYNC); - if (info->fd == -1) { + if (info->fd < 0) { RTE_LOG(ERR, CHANNEL_MANAGER, "Error(%s) opening fifo for '%s'\n", strerror(errno), info->channel_path); diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c index 1a3a0fa768..22f2eb8194 100644 --- a/examples/vm_power_manager/channel_monitor.c +++ b/examples/vm_power_manager/channel_monitor.c @@ -435,7 +435,7 @@ update_policy(struct channel_packet *pkt) /* Copy the contents of *pkt into the policy.pkt */ policies[i].pkt = *pkt; get_pcpu_to_control(&policies[i]); - if (get_pfid(&policies[i]) == -1) { + if (get_pfid(&policies[i]) < 0) { updated = 1; break; } @@ -449,7 +449,7 @@ update_policy(struct channel_packet *pkt) if (policies[i].enabled == 0) { policies[i].pkt = *pkt; get_pcpu_to_control(&policies[i]); - if (get_pfid(&policies[i]) == -1) + if (get_pfid(&policies[i]) < 0) break; core_share_status(i); policies[i].enabled = 1; @@ -756,7 +756,7 @@ read_binary_packet(struct channel_info *chan_info) buffer, buffer_len); if (n_bytes == buffer_len) break; - if (n_bytes == -1) { + if (n_bytes < 0) { err = errno; RTE_LOG(DEBUG, CHANNEL_MONITOR, "Received error on " -- 2.20.1