From 25f5b7c78cba334ba1c9024694b97b37d84458cb Mon Sep 17 00:00:00 2001 From: Qi Zhang Date: Thu, 31 Oct 2019 11:55:21 +0800 Subject: [PATCH] net/ice/base: fix symmetric hash configure When a new hash profile is created, we need to reset all related GLQF_HSYMM registers, otherwise unexpected hash behaviour may happen on packet that hits that profile. The patch fixes the issue that we only do reset when symmetric hash is required, but actually for non symmetric hash we also need this, since GLQF_HSYMM might be polluted by previous configuration. Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS") Signed-off-by: Qi Zhang Tested-by: Simei Su Acked-by: Xiaolong Ye --- drivers/net/ice/base/ice_flow.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 6264e77479..391df1b540 100644 --- a/drivers/net/ice/base/ice_flow.c +++ b/drivers/net/ice/base/ice_flow.c @@ -2191,8 +2191,6 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds, status = ice_add_rss_list(hw, vsi_handle, prof); prof->cfg.symm = symm; - if (!symm) - goto exit; update_symm: ice_rss_update_symm(hw, prof); -- 2.20.1