From 2c007ea106161917270ed14a21471de5cc38ab0c Mon Sep 17 00:00:00 2001 From: Tomasz Kulasek Date: Thu, 7 Apr 2016 16:02:13 +0200 Subject: [PATCH] app/test: fix array overflow warning with gcc 4.5 DPDK/app/test/test_cryptodev.c: In function 'test_snow3g_encrypted_authentication.clone.3': DPDK/x86_64-ivshmem-linuxapp-gcc/include/rte_memcpy.h:796:14: error: array subscript is above array bounds In lines like: rte_memcpy(sym_op->cipher.iv.data, iv, iv_len); when "iv" is 64 bytes long array, and "iv_len" is "unsigned int", compiler tries to evaluate also a code for array size larger than 255 bytes long and reports error "array subscript is above array bounds" in line: rte_memcpy.h:796 rte_mov128((uint8_t *)dst + 128, (const uint8_t *)src + 128); caused by evaluation to: rte_mov128((uint8_t *)sym_op->cipher.iv.data + 128, (const uint8_t *)iv + 128); where "iv" is 64 bytes long buffer and "iv + 128" point out of it, gcc 4.5. Using uint8_t as a size of copied block prevents to evaluate in rte_memcpy code for length bigger than 255, causing the problem. Fixes: 8bdf665fe6c0 ("app/test: add SNOW 3G") Signed-off-by: Tomasz Kulasek Acked-by: Pablo de Lara --- app/test/test_cryptodev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 0c26804d58..8e8da988a4 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -2362,10 +2362,10 @@ create_snow3g_hash_operation(const uint8_t *auth_tag, static int create_snow3g_cipher_hash_operation(const uint8_t *auth_tag, const unsigned auth_tag_len, - const uint8_t *aad, const unsigned aad_len, + const uint8_t *aad, const uint8_t aad_len, unsigned data_pad_len, enum rte_crypto_auth_operation op, - const uint8_t *iv, const unsigned iv_len, + const uint8_t *iv, const uint8_t iv_len, const unsigned cipher_len, const unsigned cipher_offset, const unsigned auth_len, const unsigned auth_offset) { @@ -2460,8 +2460,8 @@ create_snow3g_cipher_hash_operation(const uint8_t *auth_tag, static int create_snow3g_auth_cipher_operation(const unsigned auth_tag_len, - const uint8_t *iv, const unsigned iv_len, - const uint8_t *aad, const unsigned aad_len, + const uint8_t *iv, const uint8_t iv_len, + const uint8_t *aad, const uint8_t aad_len, unsigned data_pad_len, const unsigned cipher_len, const unsigned cipher_offset, const unsigned auth_len, const unsigned auth_offset) -- 2.20.1