From 360495d4831fa754028ac12d108f6cda9250f840 Mon Sep 17 00:00:00 2001 From: Qiming Yang Date: Mon, 14 Jan 2019 21:35:30 +0800 Subject: [PATCH 1/1] net/ice: fix VLAN filter Tx This patch fixed Tx error and allowed untagged packets in when vlan filter on. Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") Signed-off-by: Qiming Yang Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 5545f3820c..b145d9c64d 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2183,14 +2183,20 @@ ice_vsi_config_vlan_filter(struct ice_vsi *vsi, bool on) if (ret) { PMD_DRV_LOG(INFO, "Update VSI failed to %s vlan rx pruning", on ? "enable" : "disable"); - ret = -EINVAL; + return -EINVAL; } else { vsi->info.valid_sections |= rte_cpu_to_le_16(ICE_AQ_VSI_PROP_SW_VALID | ICE_AQ_VSI_PROP_SECURITY_VALID); } - return ret; + /* consist with other drivers, allow untagged packet when vlan filter on */ + if (on) + ret = ice_add_vlan_filter(vsi, 0); + else + ret = ice_remove_vlan_filter(vsi, 0); + + return 0; } static int -- 2.20.1