From 3be12ea52ad8c7050bfb7b936b75edf20eea4292 Mon Sep 17 00:00:00 2001 From: Lee Daly Date: Mon, 19 Nov 2018 13:52:53 +0000 Subject: [PATCH] test/compress: improve debug trace setup This removes the magic number from the assignment of the engine variable, which is used in the debug trace. Signed-off-by: Lee Daly Acked-by: Tomasz Jozwiak --- test/test/test_compressdev.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/test/test/test_compressdev.c b/test/test/test_compressdev.c index 5d5e5190b1..dab3c12ecb 100644 --- a/test/test/test_compressdev.c +++ b/test/test/test_compressdev.c @@ -857,11 +857,9 @@ test_deflate_comp_decomp(const char * const test_bufs[], &compress_xforms[xform_idx]->compress; enum rte_comp_huffman huffman_type = compress_xform->deflate.huffman; - char engine[22]; - if (zlib_dir == ZLIB_COMPRESS || zlib_dir == ZLIB_ALL) - strlcpy(engine, "zlib (direct, no pmd)", 22); - else - strlcpy(engine, "pmd", 22); + char engine[] = "zlib (directly, not PMD)"; + if (zlib_dir != ZLIB_COMPRESS || zlib_dir != ZLIB_ALL) + strlcpy(engine, "PMD", sizeof(engine)); RTE_LOG(DEBUG, USER1, "Buffer %u compressed by %s from %u to" " %u bytes (level = %d, huffman = %s)\n", @@ -1066,11 +1064,9 @@ test_deflate_comp_decomp(const char * const test_bufs[], for (i = 0; i < num_bufs; i++) { priv_data = (struct priv_op_data *)(ops_processed[i] + 1); - char engine[22]; - if (zlib_dir == ZLIB_DECOMPRESS || zlib_dir == ZLIB_ALL) - strlcpy(engine, "zlib (direct, no pmd)", 22); - else - strlcpy(engine, "pmd", 22); + char engine[] = "zlib, (directly, no PMD)"; + if (zlib_dir != ZLIB_DECOMPRESS || zlib_dir != ZLIB_ALL) + strlcpy(engine, "pmd", sizeof(engine)); RTE_LOG(DEBUG, USER1, "Buffer %u decompressed by %s from %u to %u bytes\n", buf_idx[priv_data->orig_idx], engine, -- 2.20.1