From 4fba6df9143e2534279083581b1111b5de0d6b44 Mon Sep 17 00:00:00 2001 From: Lavanya Govindarajan Date: Thu, 26 Sep 2019 14:30:05 +0100 Subject: [PATCH] app/compress-perf: fix out-of-bounds read One issue caught by Coverity 344984 *overrun-local: Overrunning array cperf_test_type_strs of 2 8-byte elements The array cperf_test_type_strs defined in app/test-compress-perf conflicts with the same name being defined in app/test-crypto-perf. Due to which coverity reports error. The fix is to rename "cperf_test_type_strs" into "comp_perf_test_type_strs" in app/test-compress-perf to avoid name confusion. Coverity issue: 344984 Fixes: 424dd6c8c1 ("app/compress-perf: add weak functions for multicore test") Fixes: 1a9b0f3504 ("app/compress-perf: add --ptest option") Fixes: 424dd6c8c1 ("app/compress-perf: add weak functions for multicore test") Cc: stable@dpdk.org Signed-off-by: Lavanya Govindarajan Acked-by: Akhil Goyal --- app/test-compress-perf/comp_perf_options.h | 2 +- app/test-compress-perf/comp_perf_options_parse.c | 4 ++-- app/test-compress-perf/main.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-compress-perf/comp_perf_options.h b/app/test-compress-perf/comp_perf_options.h index 651cbea4e2..e98d93c2fb 100644 --- a/app/test-compress-perf/comp_perf_options.h +++ b/app/test-compress-perf/comp_perf_options.h @@ -11,7 +11,7 @@ #define MAX_MBUF_DATA_SIZE (UINT16_MAX - RTE_PKTMBUF_HEADROOM) #define MAX_SEG_SIZE ((int)(MAX_MBUF_DATA_SIZE / EXPANSE_RATIO)) -extern const char *cperf_test_type_strs[]; +extern const char *comp_perf_test_type_strs[]; /* Cleanup state machine */ enum cleanup_st { diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c index 01e19eafb0..fa4fd0b417 100644 --- a/app/test-compress-perf/comp_perf_options_parse.c +++ b/app/test-compress-perf/comp_perf_options_parse.c @@ -82,11 +82,11 @@ parse_cperf_test_type(struct comp_test_data *test_data, const char *arg) { struct name_id_map cperftest_namemap[] = { { - cperf_test_type_strs[CPERF_TEST_TYPE_BENCHMARK], + comp_perf_test_type_strs[CPERF_TEST_TYPE_BENCHMARK], CPERF_TEST_TYPE_BENCHMARK }, { - cperf_test_type_strs[CPERF_TEST_TYPE_VERIFY], + comp_perf_test_type_strs[CPERF_TEST_TYPE_VERIFY], CPERF_TEST_TYPE_VERIFY } }; diff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c index 6f095b5484..6b56dd6809 100644 --- a/app/test-compress-perf/main.c +++ b/app/test-compress-perf/main.c @@ -21,7 +21,7 @@ #define NUM_MAX_INFLIGHT_OPS 512 __extension__ -const char *cperf_test_type_strs[] = { +const char *comp_perf_test_type_strs[] = { [CPERF_TEST_TYPE_BENCHMARK] = "benchmark", [CPERF_TEST_TYPE_VERIFY] = "verify" }; -- 2.20.1