From 5045e2b25ab1ce9ded4023b60fda7489a2b06663 Mon Sep 17 00:00:00 2001 From: Hongbo Zheng Date: Tue, 9 Jun 2020 16:44:17 +0800 Subject: [PATCH] net/hns3: fix unintended sign extension in dump operation There are coverity defects related "Unintended sign extension" in the internal static function named hns3_get_regs_length used for dumping reg operation. This patch fixes them by replacing the data type of cmdq_lines, common_lines, ring_lines and tqp_intr_lines with uint32_t in the inner static function named hns3_get_regs_length of hns3 PMD driver. Coverity issue: 349917, 349914 Fixes: 936eda25e8da ("net/hns3: support dump register") Cc: stable@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_regs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c index a3f2a51f9b..63c8602a87 100644 --- a/drivers/net/hns3/hns3_regs.c +++ b/drivers/net/hns3/hns3_regs.c @@ -116,7 +116,7 @@ static int hns3_get_regs_length(struct hns3_hw *hw, uint32_t *length) { struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw); - int cmdq_lines, common_lines, ring_lines, tqp_intr_lines; + uint32_t cmdq_lines, common_lines, ring_lines, tqp_intr_lines; uint32_t regs_num_32_bit, regs_num_64_bit; uint32_t len; int ret; -- 2.20.1