From 6801116688fe82b5b32cf45ffa7b475d1cfdcea4 Mon Sep 17 00:00:00 2001 From: Xiaoyu Min Date: Mon, 16 Dec 2019 11:27:41 +0200 Subject: [PATCH] net/mlx5: fix multiple flow table hash list The eth devices which share one ibv device only need one hash list of flow table. Currently, flow table hash list is created per each eth device whatever whether they share one ibv device or not. If the devices share one ibv device, the previously created hash list will become dangle because the pointer point to (sh->flow_tbls) is overwritten by the later created hast list. To fix this, just don't create hash list if it is already created. Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion") Cc: stable@dpdk.org Reported-by: Zhike Wang Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index d84a6f91b4..50960c91ce 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -868,8 +868,13 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) { struct mlx5_ibv_shared *sh = priv->sh; char s[MLX5_HLIST_NAMESIZE]; - int err = mlx5_alloc_table_hash_list(priv); + int err = 0; + if (!sh->flow_tbls) + err = mlx5_alloc_table_hash_list(priv); + else + DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, reuse\n", + (void *)sh->flow_tbls); if (err) return err; /* Create tags hash list table. */ -- 2.20.1