From 6db80eb7c97e7db9c006641cc7ecae46c625d64e Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 12 Mar 2018 19:31:33 +0000 Subject: [PATCH] net/tap: fix icc build build error: .../dpdk/drivers/net/tap/rte_eth_tap.c(598): error #279: controlling expression is constant RTE_ASSERT(!"unsupported request type: must not happen"); Although RTE_ASSERT helps debugging this issue when assert enabled, constant expression in assert means this path can be taken during runtime and there is no protection against it when assert is disabled. Adding error log and error return back, replacing RTE_ASSERT. Fixes: 7748a4b44196 ("net/tap: add debug messages") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Pablo de Lara --- drivers/net/tap/rte_eth_tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 8bea2662ce..ef33aace91 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -621,7 +621,9 @@ apply: case SIOCSIFMTU: break; default: - RTE_ASSERT(!"unsupported request type: must not happen"); + RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n", + pmd->name); + return -EINVAL; } if (ioctl(pmd->ioctl_sock, request, ifr) < 0) goto error; -- 2.20.1