From 7eeda4d55af439495e7463f94cd30bfa39bd39d5 Mon Sep 17 00:00:00 2001 From: Hariprasad Govindharajan Date: Thu, 20 Feb 2020 17:39:03 +0000 Subject: [PATCH] app/testpmd: fix return of port list parser The function parse_port_list() is designed to return unsigned int value. After sanitizing the inputs, it is returning -1. Changed it to return 0. Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") Signed-off-by: Hariprasad Govindharajan Acked-by: Bernard Iremonger Reviewed-by: Ferruh Yigit --- app/test-pmd/config.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index d93941f031..8cf84ccd31 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2616,9 +2616,6 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt) * If the user wants to use only the ports 1,2 then the input * is 1,2. * valid characters are '-' and ',' - * invalid chars like '.' or '#' will result in - * EAL: Error - exiting with code: 1 - * Cause: Invalid fwd port list * @param[out] values * This array will be filled with a list of port IDs * based on the user input @@ -2630,7 +2627,8 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt) * 1) Number of elements in the values array * 2) Maximum value of each element in the values array * @return - * -returns total count of parsed port IDs + * On success, returns total count of parsed port IDs + * On failure, returns 0 */ static unsigned int parse_port_list(const char *list, unsigned int *values, unsigned int maxsize) @@ -2642,7 +2640,7 @@ parse_port_list(const char *list, unsigned int *values, unsigned int maxsize) unsigned int marked[maxsize]; if (list == NULL || values == NULL) - return -1; + return 0; for (i = 0; i < (int)maxsize; i++) marked[i] = 0; -- 2.20.1