From 7fb1e84570eb61e508a097176a2f5b046d417311 Mon Sep 17 00:00:00 2001 From: Aaron Conole Date: Wed, 7 Aug 2019 10:58:44 -0400 Subject: [PATCH] test/mcslock: wait for lcore completion It's possible that the mcsunlock occurs before the test_mcslock_try has a chance to execute, which will result in the trylock being successful, making the test case fail. Fix this by waiting until all lcores have completed their test before unlocking the master lock. Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test") Signed-off-by: Aaron Conole Acked-by: Phil Yang Reviewed-by: David Marchand --- app/test/test_mcslock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_mcslock.c b/app/test/test_mcslock.c index ed384b81d9..e9359df2ee 100644 --- a/app/test/test_mcslock.c +++ b/app/test/test_mcslock.c @@ -225,8 +225,8 @@ test_mcslock(void) RTE_LCORE_FOREACH_SLAVE(i) { rte_eal_remote_launch(test_mcslock_try, NULL, i); } - rte_mcslock_unlock(&p_ml_try, &ml_try_me); rte_eal_mp_wait_lcore(); + rte_mcslock_unlock(&p_ml_try, &ml_try_me); /* Test is_locked API */ if (rte_mcslock_is_locked(p_ml)) { -- 2.20.1