From 84ac1559c455e5ef02bc77f6a19855037eccad01 Mon Sep 17 00:00:00 2001 From: Dongsu Han Date: Mon, 6 May 2013 12:06:51 +0000 Subject: [PATCH] app/testpmd: fix refcnt in mbuf allocation test-pmd txonly leaks mbuf from the pool. The function tx_mbuf_alloc() does not change the refcnt and the refcnt is 0 when it is first allocated. However, rte_pktmbuf_free_seg called by the driver's xmit code decrements reference count to -1. So mbuf never goes back to the pool. As a result, txonly can't send packets after it exhausts the mempool. The function tx_mbuf_alloc() was getting mbuf directly from mempool and so was bypassing mbuf API. The dedicated function is rte_pktmbuf_alloc() but it is much slower because it does unnecessary initializations in rte_pktmbuf_reset(). By using the internal API __rte_mbuf_raw_alloc(), refcnt is correctly handled without adding too much overload. Signed-off-by: Dongsu Han Signed-off-by: Thomas Monjalon Acked-by: Adrien Mazarguil --- app/test-pmd/txonly.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index 7f3b89ccb4..63cc47a6cb 100644 --- a/app/test-pmd/txonly.c +++ b/app/test-pmd/txonly.c @@ -92,11 +92,8 @@ static inline struct rte_mbuf * tx_mbuf_alloc(struct rte_mempool *mp) { struct rte_mbuf *m; - void *mb; - if (rte_mempool_get(mp, &mb) < 0) - return NULL; - m = (struct rte_mbuf *)mb; + m = __rte_mbuf_raw_alloc(mp); __rte_mbuf_sanity_check(m, RTE_MBUF_PKT, 1); return m; } -- 2.20.1