From 86fe881c03cf1aa3e93c5e6534b9974f7350f823 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Fri, 13 Oct 2017 11:30:21 +0200 Subject: [PATCH] vhost: fetch ring address after NUMA reallocation In case of NUMA reallocation, the virtqueue struct is reallocated on another socket, meaning that its address changes. In translate_ring_addresses(), addr pointer was not fetched again after the reallocation, so it pointed to freed memory. This patch just fetch again addr pointer after the reallocation. Reported-by: Lei Yao Signed-off-by: Maxime Coquelin Tested-by: Lei Yao Reviewed-by: Jens Freimann --- lib/librte_vhost/vhost_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 1dfb234ca1..76c4eeca51 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -420,6 +420,7 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index) dev = numa_realloc(dev, vq_index); vq = dev->virtqueue[vq_index]; + addr = &vq->ring_addrs; vq->avail = (struct vring_avail *)(uintptr_t)ring_addr_to_vva(dev, vq, addr->avail_user_addr, sizeof(struct vring_avail)); -- 2.20.1