From 89626cb570bcd43fc4da9f5cb0949aaef25bd6ce Mon Sep 17 00:00:00 2001 From: Xuelin Shi Date: Thu, 12 Feb 2015 09:26:52 +0800 Subject: [PATCH] e1000: fix big endian access e1000 is little endian, but cpu maybe not. add necessary conversions. rte_cpu_to_le_32(...) for PCI write rte_le_to_cpu_32(...) for PCI read. Signed-off-by: Xuelin Shi Acked-by: Thomas Monjalon --- lib/librte_pmd_e1000/e1000/e1000_osdep.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_e1000/e1000/e1000_osdep.h b/lib/librte_pmd_e1000/e1000/e1000_osdep.h index 438641e216..d04ec732f6 100644 --- a/lib/librte_pmd_e1000/e1000/e1000_osdep.h +++ b/lib/librte_pmd_e1000/e1000/e1000_osdep.h @@ -43,6 +43,7 @@ #include #include #include +#include #include "../e1000_logs.h" @@ -96,7 +97,7 @@ typedef int bool; #define E1000_PCI_REG(reg) (*((volatile uint32_t *)(reg))) #define E1000_PCI_REG_WRITE(reg, value) do { \ - E1000_PCI_REG((reg)) = (value); \ + E1000_PCI_REG((reg)) = (rte_cpu_to_le_32(value)); \ } while (0) #define E1000_PCI_REG_ADDR(hw, reg) \ @@ -107,7 +108,7 @@ typedef int bool; static inline uint32_t e1000_read_addr(volatile void* addr) { - return E1000_PCI_REG(addr); + return rte_le_to_cpu_32(E1000_PCI_REG(addr)); } /* Necessary defines */ -- 2.20.1