From 8ec87289e5eb0af241e01dfded5b7b5e163c5b25 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Wed, 28 Apr 2021 16:36:59 +0800 Subject: [PATCH] app/testpmd: change port link speed without stopping all When we use the following cmd to modify the link speed of specified port: "port config speed xxx duplex xxx", we have to stop all ports. It's not necessary. Fixes: 82113036e4e5 ("ethdev: redesign link speed config") Cc: stable@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) Acked-by: Ferruh Yigit Acked-by: Xiaoyun Li --- app/test-pmd/cmdline.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index bfd2fb9240..8468018cf3 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1619,13 +1619,13 @@ cmd_config_speed_specific_parsed(void *parsed_result, struct cmd_config_speed_specific *res = parsed_result; uint32_t link_speed; - if (!all_ports_stopped()) { - printf("Please stop all ports first\n"); + if (port_id_is_invalid(res->id, ENABLED_WARN)) return; - } - if (port_id_is_invalid(res->id, ENABLED_WARN)) + if (!port_is_stopped(res->id)) { + printf("Please stop port %d first\n", res->id); return; + } if (parse_and_check_speed_duplex(res->value1, res->value2, &link_speed) < 0) -- 2.20.1