From 9486d60b94b58932c6da1163df2118549fa57224 Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Wed, 4 Apr 2018 16:06:03 +0800 Subject: [PATCH 1/1] net/i40e: fix flow RSS queue index check There need a queue index check for RSS queue region in order to aviod error from configuration. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: stable@dpdk.org Signed-off-by: Wei Zhao Tested-by: Yuan Peng Acked-by: Qi Zhang --- drivers/net/i40e/i40e_flow.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 0a569c2b2f..a32ad9b588 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -4216,6 +4216,32 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, } } + if (conf_info->queue_region_number) { + for (i = 0; i < rss->num; i++) { + for (j = 0; j < rss_info->num; j++) { + if (rss->queue[i] == rss_info->queue[j]) + break; + } + if (j == rss_info->num) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + act, + "no valid queues"); + return -rte_errno; + } + } + + for (i = 0; i < rss->num - 1; i++) { + if (rss->queue[i + 1] != rss->queue[i] + 1) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + act, + "no valid queues"); + return -rte_errno; + } + } + } + for (n = 0; n < conf_info->queue_region_number; n++) { if (conf_info->region[n].user_priority_num || conf_info->region[n].flowtype_num) { -- 2.20.1