From 9b60795143bbdf03bcf266492f72c4286d316c71 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Mon, 16 Apr 2018 17:03:11 +0100 Subject: [PATCH] examples/ip_pipeline: fix leak on DSCP parsing Close the file stream before returning from the function to avoid memory leak. Coverity issue: 272605 Fixes: 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update command") Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index 199a31ff89..20fbefb809 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -4158,6 +4158,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table, if (parse_tokenize_string(line, tokens, &n_tokens)) { *line_number = l; + fclose(f); return -EINVAL; } @@ -4172,6 +4173,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table, (tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) || (strlen(tokens[2]) != 1)) { *line_number = l; + fclose(f); return -EINVAL; } @@ -4193,6 +4195,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table, default: *line_number = l; + fclose(f); return -EINVAL; } -- 2.20.1