From a5e20775a7588042c64f3919787b689f1c861369 Mon Sep 17 00:00:00 2001 From: Daniel Mrzyglod Date: Tue, 10 May 2016 18:11:18 +0200 Subject: [PATCH] vhost: fix name not null terminated Fix issue reported by Coverity. Coverity ID 124556 If the buffer is treated as a null terminated string in later operations, a buffer overflow or over-read may occur. In vhost_set_ifname: The string buffer may not have a null terminator if the source string's length is equal to the buffer size Fixes: 54292e9520e0 ("vhost: support ifname for vhost-user") Signed-off-by: Daniel Mrzyglod Acked-by: Yuanhan Liu --- lib/librte_vhost/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c index d870ad97ab..f4695afd48 100644 --- a/lib/librte_vhost/virtio-net.c +++ b/lib/librte_vhost/virtio-net.c @@ -320,6 +320,7 @@ vhost_set_ifname(struct vhost_device_ctx ctx, sizeof(dev->ifname) : if_len; strncpy(dev->ifname, if_name, len); + dev->ifname[sizeof(dev->ifname) - 1] = '\0'; } -- 2.20.1