From c69601c4b591652d8091e8a216eb5030cbede10d Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 30 May 2016 13:56:46 +0200 Subject: [PATCH] kni: fix build clean on Ubuntu MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The $(comma) variable is not defined in this Makefile, nor in any included Makefile. Seen while doing a "make clean" on ubuntu: $ make clean == Clean lib == Clean lib/librte_compat == Clean lib/librte_eal == Clean lib/librte_eal/common == Clean lib/librte_eal/linuxapp == Clean lib/librte_eal/linuxapp/eal == Clean lib/librte_eal/linuxapp/igb_uio == Clean lib/librte_eal/linuxapp/kni tr: missing operand after ‘.-’ Two strings must be given when translating. Try 'tr --help' for more information. This commit replaces $(comma) by a ',' character, it's not a problem in that case since we are inside antiquotes. Fixes: a09b359daca3 ("kni: fix build on Ubuntu 14.04") Signed-off-by: Olivier Matz Acked-by Ferruh Yigit --- lib/librte_eal/linuxapp/kni/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/kni/Makefile b/lib/librte_eal/linuxapp/kni/Makefile index ac99d3f147..8cc6b61c56 100644 --- a/lib/librte_eal/linuxapp/kni/Makefile +++ b/lib/librte_eal/linuxapp/kni/Makefile @@ -47,7 +47,7 @@ MODULE_CFLAGS += -Wall -Werror ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu) MODULE_CFLAGS += -DUBUNTU_RELEASE_CODE=$(shell lsb_release -sr | tr -d .) UBUNTU_KERNEL_CODE := $(shell echo `grep UTS_RELEASE $(RTE_KERNELDIR)/include/generated/utsrelease.h \ - | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1) + | cut -d '"' -f2 | cut -d- -f1,2 | tr .- ,`,1) MODULE_CFLAGS += -D"UBUNTU_KERNEL_CODE=UBUNTU_KERNEL_VERSION($(UBUNTU_KERNEL_CODE))" endif -- 2.20.1