From c98e8f3932d88f77c7f1acd7551406200795c5aa Mon Sep 17 00:00:00 2001 From: Remy Horton Date: Thu, 10 Dec 2015 09:50:06 +0000 Subject: [PATCH] examples/ethtool: fix uninitialised variable Fix Coverity warning with uninitialised field in structure being used. Zero out all the other unused ones. >>> CID 120413 (#1 of 1): Uninitialized scalar variable (UNINIT) Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") Signed-off-by: Remy Horton Acked-by: John McNamara --- examples/ethtool/ethtool-app/ethapp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c index 3863b02561..2ed4796dd7 100644 --- a/examples/ethtool/ethtool-app/ethapp.c +++ b/examples/ethtool/ethtool-app/ethapp.c @@ -339,6 +339,7 @@ pcmd_pause_callback(void *ptr_params, if (ptr_data != NULL) { stat = rte_ethtool_get_pauseparam(params->port, &info); } else { + memset(&info, 0, sizeof(info)); if (strcasecmp("all", params->opt) == 0) { info.tx_pause = 1; info.rx_pause = 1; @@ -352,6 +353,8 @@ pcmd_pause_callback(void *ptr_params, info.tx_pause = 0; info.rx_pause = 0; } + /* Assume auto-negotiation wanted */ + info.autoneg = 1; stat = rte_ethtool_set_pauseparam(params->port, &info); } if (stat == 0) { -- 2.20.1