From d601426a2711f396201817bb077ec4f73c3faffe Mon Sep 17 00:00:00 2001 From: Sunil Kumar Kori Date: Tue, 16 Jul 2019 11:53:28 +0530 Subject: [PATCH] ip_frag: remove remaining IP checkum offload flag Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during fragmentation operation implicitly by the library. Because of this, application is forced to use checksum offload whether it is supported by platform or not. Also documentation does not provide any expected value of ol_flags in returned fragmented mbufs so application will never come to know that which offloads are enabled. So transmission may be failed for the platforms which does not support checksum offload. So removing mentioned flag from the library. Mentioned change is part of http://patches.dpdk.org/patch/53475. Changes for reassembly operation is already accepted. This patch set implements the similar change for fragmentation operation. Fixes: e29fc44370c2 ("ip_frag: remove IP checkum offload flag") Signed-off-by: Sunil Kumar Kori --- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c index 221d74e1d2..9e9f986cc5 100644 --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c @@ -173,7 +173,6 @@ rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in, fragment_offset = (uint16_t)(fragment_offset + out_pkt->pkt_len - sizeof(struct rte_ipv4_hdr)); - out_pkt->ol_flags |= PKT_TX_IP_CKSUM; out_pkt->l3_len = sizeof(struct rte_ipv4_hdr); /* Write the fragment to the output list */ -- 2.20.1