From: Fady Bader Date: Wed, 22 Apr 2020 07:37:44 +0000 (+0300) Subject: mempool: remove inline functions from export list X-Git-Url: http://git.droids-corp.org/?p=dpdk.git;a=commitdiff_plain;h=036d82365e7e26adc5061cae49778f96c431e697 mempool: remove inline functions from export list The code didn't compile when using exported mempool functions under Windows. compilation error logs: rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_cache_flush rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_default_cache rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_generic_get rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_generic_put lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals clang: error: linker command failed with exit code 1120 (use -v to see invocation) The cause was that there were some inline functions that were included in the export list. To solve this the functions, which are implemented in the header and shouldn't be exported, were removed from rte_mempool_version.map export list. Fixes: 4b5062755aa7 ("mempool: allow user-owned cache") Fixes: 656f2d3ede96 ("mempool: deprecate specific get and put functions") Cc: stable@dpdk.org Signed-off-by: Fady Bader Acked-by: Andrew Rybchenko --- diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map index 4fffd3ea41..695dd6e04f 100644 --- a/lib/librte_mempool/rte_mempool_version.map +++ b/lib/librte_mempool/rte_mempool_version.map @@ -4,18 +4,14 @@ DPDK_20.0 { rte_mempool_audit; rte_mempool_avail_count; rte_mempool_cache_create; - rte_mempool_cache_flush; rte_mempool_cache_free; rte_mempool_calc_obj_size; rte_mempool_check_cookies; rte_mempool_contig_blocks_check_cookies; rte_mempool_create; rte_mempool_create_empty; - rte_mempool_default_cache; rte_mempool_dump; rte_mempool_free; - rte_mempool_generic_get; - rte_mempool_generic_put; rte_mempool_in_use_count; rte_mempool_list_dump; rte_mempool_lookup;