From: Xueming Li Date: Wed, 6 Jan 2021 03:06:30 +0000 (+0000) Subject: vdpa/mlx5: add hardware queue moderation X-Git-Url: http://git.droids-corp.org/?p=dpdk.git;a=commitdiff_plain;h=1f93bee4e77cb634235a8346ae01297a80a32c4e vdpa/mlx5: add hardware queue moderation The next parameters control the HW queue moderation feature. This feature helps to control the traffic performance and latency trade-off. Each packet completion report from HW to SW requires CQ processing by SW and triggers interrupt for the guest driver. Interrupt report and handling cost CPU cycles and time and the amount of this affects directly on packet performance and latency. hw_latency_mode parameters [int] 0, HW default. 1, Latency is counted from the first packet completion report. 2, Latency is counted from the last packet completion. hw_max_latency_us parameters [int] 0 - 4095, The maximum time in microseconds that packet completion report can be delayed. hw_max_pending_comp parameter [int] 0 - 65535, The maximum number of pending packets completions in an HW queue. Signed-off-by: Xueming Li Reviewed-by: Maxime Coquelin --- diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst index 730e171ba3..1f2ae6fb92 100644 --- a/doc/guides/vdpadevs/mlx5.rst +++ b/doc/guides/vdpadevs/mlx5.rst @@ -139,6 +139,30 @@ Driver options CPU core number to set polling thread affinity to, default to control plane cpu. +- ``hw_latency_mode`` parameter [int] + + The completion queue moderation mode: + + - 0, HW default. + + - 1, Latency is counted from the first packet completion report. + + - 2, Latency is counted from the last packet completion. + +- ``hw_max_latency_us`` parameter [int] + + - 1 - 4095, The maximum time in microseconds that packet completion report + can be delayed. + + - 0, HW default. + +- ``hw_max_pending_comp`` parameter [int] + + - 1 - 65535, The maximum number of pending packets completions in an HW queue. + + - 0, HW default. + + Error handling ^^^^^^^^^^^^^^ diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 5d954d48ce..0f22a863a3 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c @@ -636,6 +636,12 @@ mlx5_vdpa_args_check_handler(const char *key, const char *val, void *opaque) DRV_LOG(WARNING, "Invalid event_core %s.", val); else priv->event_core = tmp; + } else if (strcmp(key, "hw_latency_mode") == 0) { + priv->hw_latency_mode = (uint32_t)tmp; + } else if (strcmp(key, "hw_max_latency_us") == 0) { + priv->hw_max_latency_us = (uint32_t)tmp; + } else if (strcmp(key, "hw_max_pending_comp") == 0) { + priv->hw_max_pending_comp = (uint32_t)tmp; } else { DRV_LOG(WARNING, "Invalid key %s.", key); } diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.h b/drivers/vdpa/mlx5/mlx5_vdpa.h index b4dd3834aa..cf6b90e8e9 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.h +++ b/drivers/vdpa/mlx5/mlx5_vdpa.h @@ -135,6 +135,9 @@ struct mlx5_vdpa_priv { uint32_t event_us; uint32_t timer_delay_us; uint32_t no_traffic_time_s; + uint8_t hw_latency_mode; /* Hardware CQ moderation mode. */ + uint16_t hw_max_latency_us; /* Hardware CQ moderation period in usec. */ + uint16_t hw_max_pending_comp; /* Hardware CQ moderation counter. */ struct rte_vdpa_device *vdev; /* vDPA device. */ int vid; /* vhost device id. */ struct ibv_context *ctx; /* Device context. */ diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c index 3e882e4000..332753fd62 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c @@ -327,6 +327,9 @@ mlx5_vdpa_virtq_setup(struct mlx5_vdpa_priv *priv, int index) attr.tis_id = priv->tiss[(index / 2) % priv->num_lag_ports]->id; attr.queue_index = index; attr.pd = priv->pdn; + attr.hw_latency_mode = priv->hw_latency_mode; + attr.hw_max_latency_us = priv->hw_max_latency_us; + attr.hw_max_pending_comp = priv->hw_max_pending_comp; virtq->virtq = mlx5_devx_cmd_create_virtq(priv->ctx, &attr); virtq->priv = priv; if (!virtq->virtq)