From: Bruce Richardson Date: Fri, 14 Apr 2017 15:18:15 +0000 (+0100) Subject: event/sw: fix events mis-identified as needing reorder X-Git-Tag: spdx-start~3491 X-Git-Url: http://git.droids-corp.org/?p=dpdk.git;a=commitdiff_plain;h=2e516d18dc013e603114011096259b30ce6a00de event/sw: fix events mis-identified as needing reorder When taking events from a port, we checked the history list to check if the event needed to be put back in order i.e. originally came from a reordered queue type. The check for reordering involved checking if the reorder buffer entry pointer was null. However, after that pointer was used it was never cleared to null again. This caused problems when we had mixed reordered and atomic or parallel events, as the events from the latter two queue types were misidentified as needing reordering. This let in some cases to crashes, but mostly led to dropping events, and then application lock-up. Fixes: 617995dfc5b2 ("event/sw: add scheduling logic") Signed-off-by: Bruce Richardson Acked-by: Harry van Haaren --- diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c index e008b519ef..a333a6f0a0 100644 --- a/drivers/event/sw/sw_evdev_scheduler.c +++ b/drivers/event/sw/sw_evdev_scheduler.c @@ -448,6 +448,7 @@ __pull_port_lb(struct sw_evdev *sw, uint32_t port_id, int allow_reorder) struct reorder_buffer_entry *rob_entry = hist_entry->rob_entry; + hist_entry->rob_entry = NULL; /* Although fragmentation not currently * supported by eventdev API, we support it * here. Open: How do we alert the user that