From: Stephen Hemminger Date: Fri, 1 Nov 2019 20:12:55 +0000 (-0700) Subject: app/testpmd: block xstats for hidden ports X-Git-Url: http://git.droids-corp.org/?p=dpdk.git;a=commitdiff_plain;h=bd67b6772492cdd9f7249bdff7163e9698bdcc16 app/testpmd: block xstats for hidden ports All the other testpmd commands block access to devices that are owned. Looks like xstat got overlooked. Fixes: bfd5051b43b5 ("app/testpmd: new command to get extended statistics") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Bernard Iremonger --- diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index b6039749cb..2a51d96644 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -238,6 +238,10 @@ nic_xstats_display(portid_t port_id) int cnt_xstats, idx_xstat; struct rte_eth_xstat_name *xstats_names; + if (port_id_is_invalid(port_id, ENABLED_WARN)) { + print_valid_ports(); + return; + } printf("###### NIC extended statistics for port %-2d\n", port_id); if (!rte_eth_dev_is_valid_port(port_id)) { printf("Error: Invalid port number %i\n", port_id); @@ -295,6 +299,10 @@ nic_xstats_clear(portid_t port_id) { int ret; + if (port_id_is_invalid(port_id, ENABLED_WARN)) { + print_valid_ports(); + return; + } ret = rte_eth_xstats_reset(port_id); if (ret != 0) { printf("%s: Error: failed to reset xstats (port %u): %s",