From: Shijith Thotton Date: Tue, 6 Jun 2017 11:04:34 +0000 (+0530) Subject: net/liquidio: fix MTU calculation from port configuration X-Git-Tag: spdx-start~3044 X-Git-Url: http://git.droids-corp.org/?p=dpdk.git;a=commitdiff_plain;h=dc7037ba73f84c8bc5923813e0398f3c1c28de9d net/liquidio: fix MTU calculation from port configuration max_rx_pkt_len member of port RX configuration indicates max frame length. Ethernet header and CRC length should be subtracted from it to find MTU. Fixes: 605164c8e79d ("net/liquidio: add API to validate VF MTU") Cc: stable@dpdk.org Signed-off-by: Shijith Thotton --- diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index 94caa907f3..479936a52f 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -36,6 +36,7 @@ #include #include #include +#include #include "lio_logs.h" #include "lio_23xx_vf.h" @@ -1367,7 +1368,8 @@ lio_sync_link_state_check(void *eth_dev) static int lio_dev_start(struct rte_eth_dev *eth_dev) { - uint16_t mtu = eth_dev->data->dev_conf.rxmode.max_rx_pkt_len; + uint16_t mtu; + uint32_t frame_len = eth_dev->data->dev_conf.rxmode.max_rx_pkt_len; struct lio_device *lio_dev = LIO_DEV(eth_dev); uint16_t timeout = LIO_MAX_CMD_TIMEOUT; int ret = 0; @@ -1405,12 +1407,29 @@ lio_dev_start(struct rte_eth_dev *eth_dev) goto dev_mtu_check_error; } + if (eth_dev->data->dev_conf.rxmode.jumbo_frame == 1) { + if (frame_len <= ETHER_MAX_LEN || + frame_len > LIO_MAX_RX_PKTLEN) { + lio_dev_err(lio_dev, "max packet length should be >= %d and < %d when jumbo frame is enabled\n", + ETHER_MAX_LEN, LIO_MAX_RX_PKTLEN); + ret = -EINVAL; + goto dev_mtu_check_error; + } + mtu = (uint16_t)(frame_len - ETHER_HDR_LEN - ETHER_CRC_LEN); + } else { + /* default MTU */ + mtu = ETHER_MTU; + eth_dev->data->dev_conf.rxmode.max_rx_pkt_len = ETHER_MAX_LEN; + } + if (lio_dev->linfo.link.s.mtu != mtu) { ret = lio_dev_validate_vf_mtu(eth_dev, mtu); if (ret) goto dev_mtu_check_error; } + eth_dev->data->mtu = mtu; + return 0; dev_mtu_check_error: