From 0e985314d5f8efac3725e8bd703278713f542bbe Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 11 Sep 2017 17:13:30 +0200 Subject: [PATCH] metrics: fix compilation with -Og MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC rte_metrics.o rte_metrics.c: In function ‘rte_metrics_reg_names’: rte_metrics.c:153:22: error: ‘entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized] entry->idx_next_set = 0; ~~~~~~~~~~~~~~~~~~~~^~~ This is a false positive, gcc is not able to see that we always go in the loop at least once, initializing entry. Fix the warning by initializing entry to NULL. Signed-off-by: Olivier Matz --- lib/librte_metrics/rte_metrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c index b66a72bb09..d9404001a6 100644 --- a/lib/librte_metrics/rte_metrics.c +++ b/lib/librte_metrics/rte_metrics.c @@ -115,7 +115,7 @@ rte_metrics_reg_name(const char *name) int rte_metrics_reg_names(const char * const *names, uint16_t cnt_names) { - struct rte_metrics_meta_s *entry; + struct rte_metrics_meta_s *entry = NULL; struct rte_metrics_data_s *stats; const struct rte_memzone *memzone; uint16_t idx_name; -- 2.20.1