From 29bc629498da1a83febea81ec8935beff7e1ea16 Mon Sep 17 00:00:00 2001 From: Jingjing Wu Date: Tue, 30 Jan 2018 17:10:36 +0800 Subject: [PATCH] net/avf: fix unchecked return in link update This patch fixes the coverity CHECKED_RETURN issue. Coverity issue: 257045 Fixes: 48de41ca11f0 ("net/avf: enable link status update") Reported-by: John McNamara Signed-off-by: Jingjing Wu --- drivers/net/avf/avf_ethdev.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index b1be7f4e07..3f210b2fcc 100644 --- a/drivers/net/avf/avf_ethdev.c +++ b/drivers/net/avf/avf_ethdev.c @@ -611,9 +611,10 @@ avf_dev_link_update(struct rte_eth_dev *dev, new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); - rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link, - *(uint64_t *)&dev->data->dev_link, - *(uint64_t *)&new_link); + if (rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link, + *(uint64_t *)&dev->data->dev_link, + *(uint64_t *)&new_link) == 0) + return -1; return 0; } -- 2.20.1