From 2cb43002af29571b2aa2e18c8154a3e23e6e013f Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 27 Sep 2017 10:23:20 +0100 Subject: [PATCH] ethdev: increase device internal name length Allow sufficient space for UUID in string form (36+1). Needed to use UUID with Hyper-V. Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- doc/guides/rel_notes/deprecation.rst | 4 ---- doc/guides/rel_notes/release_17_11.rst | 5 +++++ lib/librte_eal/common/include/rte_dev.h | 6 +++++- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index f4269f0d50..4e4d97b7e6 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -64,10 +64,6 @@ Deprecation Notices done by the EAL and not by the ``ethdev`` layer anymore. Users relying on this flag being present only have to remove their checks to follow the change. -* ethdev: An ABI change is planned for 17.11 for the structure rte_eth_dev_data. - The size of the unique name will increase RTE_ETH_NAME_MAX_LEN from 32 to - 64 characters to allow using a globally unique identifier (GUID) in this field. - * ethdev: new parameters - ``rte_security_capabilities`` and ``rte_security_ops`` will be added to ``rte_eth_dev_info`` and ``rte_eth_dev`` respectively to support security operations like diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 892c6bd179..5609c30f5d 100644 --- a/doc/guides/rel_notes/release_17_11.rst +++ b/doc/guides/rel_notes/release_17_11.rst @@ -184,6 +184,11 @@ API Changes Also, make sure to start the actual text at the margin. ========================================================= +* **Ethdev device name length increased** + + The size of internal device name is increased to 64 characters + to allow for storing longer bus specific name. + * **Service cores API updated for usability** The service cores API has been changed, removing pointers from the API diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index 5386d3a28b..4c4ac7e5d3 100644 --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -152,7 +152,11 @@ struct rte_driver { const char *alias; /**< Driver alias. */ }; -#define RTE_DEV_NAME_MAX_LEN (32) +/* + * Internal identifier length + * Sufficiently large to allow for UUID or PCI address + */ +#define RTE_DEV_NAME_MAX_LEN 64 /** * A structure describing a generic device. -- 2.20.1