From 3b29f60f2d584d5086b735e0a6fab518a17eaa1e Mon Sep 17 00:00:00 2001 From: Yong Wang Date: Fri, 15 Sep 2017 07:33:08 -0400 Subject: [PATCH] buildtools: check allocation error in pmdinfogen In func locate_pmd_entries(), pointer 'new' returned from call to func 'calloc' may be NULL. It is dereferenced without null point check. Signed-off-by: Yong Wang --- buildtools/pmdinfogen/pmdinfogen.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c index e73fc7679a..96ccbf33be 100644 --- a/buildtools/pmdinfogen/pmdinfogen.c +++ b/buildtools/pmdinfogen/pmdinfogen.c @@ -327,6 +327,10 @@ static int locate_pmd_entries(struct elf_info *info) do { new = calloc(sizeof(struct pmd_driver), 1); + if (new == NULL) { + fprintf(stderr, "Failed to calloc memory\n"); + return -1; + } new->name_sym = find_sym_in_symtab(info, "this_pmd_name", last); last = new->name_sym; if (!new->name_sym) @@ -408,7 +412,8 @@ int main(int argc, char **argv) } parse_elf(&info, argv[1]); - locate_pmd_entries(&info); + if (locate_pmd_entries(&info) < 0) + exit(1); if (info.drivers) { output_pmd_info_string(&info, argv[2]); -- 2.20.1