From 617d90527f8a72e9a1a258f2e6885b46ffb6fa46 Mon Sep 17 00:00:00 2001 From: Yoni Gilad Date: Tue, 10 Jan 2017 17:14:21 +0000 Subject: [PATCH] usertools: fix active interface detection when binding When adding crypto devices, the "Active" and "Ssh_if" attributes of existing network devices were reset. This causes the following issues: - Network interfaces aren't marked as "*Active*" in the --status output. - Active network interfaces can be unbound without the --force option, causing loss of network connection. The reset was caused by the call to devices[d].update in get_crypto_details. This patch prevents the update on non-crypto devices. Fixes: cb4a1d14bf3e ("tools: bind crypto devices") Cc: stable@dpdk.org Signed-off-by: Yoni Gilad Acked-by: Pablo de Lara --- usertools/dpdk-devbind.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index e057b871b9..1b9c651553 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -328,6 +328,9 @@ def get_crypto_details(): # based on the basic info, get extended text details for d in devices.keys(): + if devices[d]["Class"][0:2] != CRYPTO_BASE_CLASS: + continue + # get additional info and add it to existing data devices[d] = devices[d].copy() devices[d].update(get_pci_device_details(d).items()) -- 2.20.1