From 661d97ba0b56897c0eb21e61a8b12a5cc227f07e Mon Sep 17 00:00:00 2001 From: Marcin Kerlin Date: Tue, 17 May 2016 10:36:57 +0200 Subject: [PATCH] cmdline: check initialization error The value returned by rdline_init() was not checked in cmdline_new(). On error, free the allocated memory and return NULL. This condition should not happen today, but it's safer to do the check in case rdline_init() is updated. Coverity issue: 13204 Fixes: af75078fece3 ("first public release") Signed-off-by: Marcin Kerlin Signed-off-by: Olivier Matz --- lib/librte_cmdline/cmdline.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_cmdline/cmdline.c b/lib/librte_cmdline/cmdline.c index c405878ee8..a9c47be3c9 100644 --- a/lib/librte_cmdline/cmdline.c +++ b/lib/librte_cmdline/cmdline.c @@ -130,6 +130,7 @@ struct cmdline * cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out) { struct cmdline *cl; + int ret; if (!ctx || !prompt) return NULL; @@ -142,8 +143,13 @@ cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out) cl->s_out = s_out; cl->ctx = ctx; - rdline_init(&cl->rdl, cmdline_write_char, - cmdline_valid_buffer, cmdline_complete_buffer); + ret = rdline_init(&cl->rdl, cmdline_write_char, cmdline_valid_buffer, + cmdline_complete_buffer); + if (ret != 0) { + free(cl); + return NULL; + } + cl->rdl.opaque = cl; cmdline_set_prompt(cl, prompt); rdline_newline(&cl->rdl, cl->prompt); -- 2.20.1