From 860806fc7b39135be23b331233ac30b242391093 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Fri, 27 Oct 2017 10:17:35 +0100 Subject: [PATCH] app/testpmd: fix memory access error for metering CLI Fix memory access (out of bounds write) error, color and action assignments. Coverity issue: 198437 Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Signed-off-by: Jasvinder Singh Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline_mtr.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index 82b0ddf1f6..d8d806d7d4 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -802,17 +802,15 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result, color = RTE_MTR_GREEN; else if (strcmp(c, "Y") == 0) color = RTE_MTR_YELLOW; - else if (strcmp(c, "Y") == 0) - color = RTE_MTR_RED; else - color = RTE_MTR_COLORS; + color = RTE_MTR_RED; /* Action */ if (strcmp(a, "G") == 0) action[color] = MTR_POLICER_ACTION_COLOR_GREEN; else if (strcmp(a, "Y") == 0) action[color] = MTR_POLICER_ACTION_COLOR_YELLOW; - else if (strcmp(a, "Y") == 0) + else if (strcmp(a, "R") == 0) action[color] = MTR_POLICER_ACTION_COLOR_RED; else action[color] = MTR_POLICER_ACTION_DROP; -- 2.20.1