From 860b1a5ff42f846d8c8657131546997b3c3b125f Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Sat, 27 Jan 2018 13:15:29 -0800 Subject: [PATCH] net/qede: remove debug config option With dynamic logging, we no longer need DEBUG INFO config option. Signed-off-by: Rasesh Mody --- config/common_base | 1 - doc/guides/nics/qede.rst | 10 +--------- drivers/net/qede/qede_ethdev.c | 8 -------- drivers/net/qede/qede_logs.h | 4 ---- 4 files changed, 1 insertion(+), 22 deletions(-) diff --git a/config/common_base b/config/common_base index c5be864b45..c560b73da7 100644 --- a/config/common_base +++ b/config/common_base @@ -317,7 +317,6 @@ CONFIG_RTE_LIBRTE_NFP_DEBUG_RX=n # QLogic 10G/25G/40G/50G/100G PMD # CONFIG_RTE_LIBRTE_QEDE_PMD=y -CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n #Provides abs path/name of the firmware file. diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index b958a5b532..43b0f3fbd7 100644 --- a/doc/guides/nics/qede.rst +++ b/doc/guides/nics/qede.rst @@ -87,14 +87,6 @@ enabling debugging options may affect system performance. Toggle compilation of QEDE PMD driver. -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO`` (default **n**) - - Toggle display of generic debugging messages. - -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER`` (default **n**) - - Toggle display of ecore related messages. - - ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **n**) Toggle display of transmit fast path run-time messages. @@ -199,7 +191,7 @@ This section provides instructions to configure SR-IOV with Linux OS. #. Running testpmd - (Enable QEDE_DEBUG_INFO=y to view informational messages): + (Supply ``--log-level="pmd.qede.driver",7`` to view informational messages): Refer to the document :ref:`compiling and testing a PMD for a NIC ` to run diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 8a69d20177..323e8ed3b1 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -357,7 +357,6 @@ qede_alloc_etherdev(struct qede_dev *qdev, struct qed_dev_eth_info *info) qdev->ops = qed_ops; } -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO static void qede_print_adapter_info(struct qede_dev *qdev) { struct ecore_dev *edev = &qdev->edev; @@ -387,7 +386,6 @@ static void qede_print_adapter_info(struct qede_dev *qdev) DP_INFO(edev, " Firmware file : %s\n", fw_file); DP_INFO(edev, "*********************************\n"); } -#endif static int qede_start_vport(struct qede_dev *qdev, uint16_t mtu) @@ -1149,9 +1147,7 @@ static void qede_prandom_bytes(uint32_t *buff) int qede_config_rss(struct rte_eth_dev *eth_dev) { struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO struct ecore_dev *edev = QEDE_INIT_EDEV(qdev); -#endif uint32_t def_rss_key[ECORE_RSS_KEY_SIZE]; struct rte_eth_rss_reta_entry64 reta_conf[2]; struct rte_eth_rss_conf rss_conf; @@ -1295,9 +1291,7 @@ static int qede_args_check(const char *key, const char *val, void *opaque) int ret = 0; struct rte_eth_dev *eth_dev = opaque; struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO struct ecore_dev *edev = QEDE_INIT_EDEV(qdev); -#endif errno = 0; tmp = strtoul(val, NULL, 0); @@ -3027,9 +3021,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops; if (do_once) { -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO qede_print_adapter_info(adapter); -#endif do_once = false; } diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index b7ecf1c276..159315e725 100644 --- a/drivers/net/qede/qede_logs.h +++ b/drivers/net/qede/qede_logs.h @@ -34,16 +34,12 @@ do { \ ##__VA_ARGS__); \ } while (0) -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO #define DP_INFO(p_dev, fmt, ...) \ rte_log(RTE_LOG_INFO, qede_logtype_driver, \ "[%s:%d(%s)]" fmt, \ __func__, __LINE__, \ (p_dev)->name ? (p_dev)->name : "", \ ##__VA_ARGS__) -#else -#define DP_INFO(p_dev, fmt, ...) do { } while (0) -#endif #define DP_VERBOSE(p_dev, module, fmt, ...) \ do { \ -- 2.20.1