From 8eb680e452ceb42a9bfa994ea822e4b1cbefcc37 Mon Sep 17 00:00:00 2001 From: Tetsuya Mukawa Date: Tue, 17 Mar 2015 13:12:41 +0900 Subject: [PATCH] pcap: fix memory leak of kvargs 'struct rte_kvargs' is allocated in rte_kvargs_parse(), and should be freed with rte_kvargs_free(). Reported-by: John Mcnamara Signed-off-by: Tetsuya Mukawa Acked-by: Neil Horman --- lib/librte_pmd_pcap/rte_eth_pcap.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pcap.c index 5e9493090b..204ae6825a 100644 --- a/lib/librte_pmd_pcap/rte_eth_pcap.c +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c @@ -888,12 +888,13 @@ rte_pmd_pcap_devinit(const char *name, const char *params) ret = rte_kvargs_process(kvlist, ETH_PCAP_IFACE_ARG, &open_rx_tx_iface, &pcaps); if (ret < 0) - return -1; + goto free_kvlist; dumpers.pcaps[0] = pcaps.pcaps[0]; dumpers.names[0] = pcaps.names[0]; dumpers.types[0] = pcaps.types[0]; - return rte_eth_from_pcaps(name, &pcaps, 1, &dumpers, 1, + ret = rte_eth_from_pcaps(name, &pcaps, 1, &dumpers, 1, numa_node, kvlist, 1); + goto free_kvlist; } /* @@ -911,7 +912,7 @@ rte_pmd_pcap_devinit(const char *name, const char *params) } if (ret < 0) - return -1; + goto free_kvlist; /* * We check whether we want to open a TX stream to a real NIC or a @@ -930,15 +931,18 @@ rte_pmd_pcap_devinit(const char *name, const char *params) } if (ret < 0) - return -1; + goto free_kvlist; if (using_dumpers) - return rte_eth_from_pcaps_n_dumpers(name, &pcaps, pcaps.num_of_rx, + ret = rte_eth_from_pcaps_n_dumpers(name, &pcaps, pcaps.num_of_rx, &dumpers, dumpers.num_of_tx, numa_node, kvlist); - - return rte_eth_from_pcaps(name, &pcaps, pcaps.num_of_rx, &dumpers, + else + ret = rte_eth_from_pcaps(name, &pcaps, pcaps.num_of_rx, &dumpers, dumpers.num_of_tx, numa_node, kvlist, 0); +free_kvlist: + rte_kvargs_free(kvlist); + return ret; } static int -- 2.20.1