From aa1a6d87f15d4407d413e6e1bd1768077ed9513a Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Thu, 31 May 2018 14:22:45 +0100 Subject: [PATCH] ethdev: force RSS offload rules again PMDs should provide supported RSS hash functions via dev_info.flow_type_rss_offloads variable. There is a check in ethdev if requested RSS hash function is supported by PMD or not. This check has been relaxed in previous release to not return an error when a non supported has function requested [1], this has been done to not break the applications. Adding the error return back. PMDs need to provide correct list of supported hash functions and applications need to take care this information before configuring the RSS otherwise they will get an error from APIs: rte_eth_dev_rss_hash_update() rte_eth_dev_configure() [1] commit af7551e2bfce ("ethdev: remove error return on RSS hash check") Signed-off-by: Ferruh Yigit Acked-by: Shahaf Shuler Acked-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 66e3116760..a9977df975 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -1194,6 +1194,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, port_id, dev_conf->rx_adv_conf.rss_conf.rss_hf, dev_info.flow_type_rss_offloads); + return -EINVAL; } /* @@ -2928,6 +2929,7 @@ rte_eth_dev_rss_hash_update(uint16_t port_id, port_id, rss_conf->rss_hf, dev_info.flow_type_rss_offloads); + return -EINVAL; } RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rss_hash_update, -ENOTSUP); return eth_err(port_id, (*dev->dev_ops->rss_hash_update)(dev, -- 2.20.1