From af14b150df78ec46de919ae4a30efbefbcd44c95 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Fri, 3 May 2019 16:34:20 +0200 Subject: [PATCH] devtools: fix check of symbol added as stable API The incriminated commit broke the detection of new symbols skipping the EXPERIMENTAL step before entering a stable ABI section. sed won't return an error, check a null output instead. Fixes: 3630757803ab ("devtools: accept experimental symbol promotion") Cc: stable@dpdk.org Signed-off-by: David Marchand --- devtools/check-symbol-change.sh | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 28f093a9fc..c5434f3bb0 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -110,15 +110,24 @@ check_for_rule_violations() # A symbol can not enter a non experimental # section directly - if [ $? -ne 0 ] && [ "$secname" != 'EXPERIMENTAL' ] + if [ -z "$oldsecname" ] then - echo -n "ERROR: symbol $symname " - echo -n "is added in the $secname " - echo -n "section, but is expected to " - echo -n "be added in the EXPERIMENTAL " - echo "section of the version map" - ret=1 - continue + if [ "$secname" = 'EXPERIMENTAL' ] + then + echo -n "INFO: symbol $symname has " + echo -n "been added to the " + echo -n "EXPERIMENTAL section of the " + echo "version map" + continue + else + echo -n "ERROR: symbol $symname " + echo -n "is added in the $secname " + echo -n "section, but is expected to " + echo -n "be added in the EXPERIMENTAL " + echo "section of the version map" + ret=1 + continue + fi fi # This symbol is moving inside a section, nothing to do -- 2.20.1