From cececca0990926769906f93b044c3d956edd0b8f Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 22 Apr 2020 15:31:30 -0700 Subject: [PATCH] common/mlx5: fix uninitialized RoCE variable MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Gcc 8.3.0 (Debian 10) complains about uninitialized variable. [474/2122] Compiling C object 'drivers/a715181@@tmp_rte_common_mlx5@sta/common_mlx5_mlx5_nl.c.o'. In file included from ../drivers/common/mlx5/mlx5_nl.h:12, from ../drivers/common/mlx5/mlx5_nl.c:23: ../drivers/common/mlx5/mlx5_nl.c: In function ‘mlx5_nl_enable_roce_get’: ../drivers/common/mlx5/mlx5_common.h:68:2: warning: ‘cur_en’ may be used uninitialized in this function [-Wmaybe-uninitialized] rte_log(RTE_LOG_ ## level, \ ^~~~~~~ ../drivers/common/mlx5/mlx5_nl.c:1560:6: note: ‘cur_en’ was declared here int cur_en; ^~~~~~ The compiler is correct, this variable would only be set if kernel netlink response message contains the DEVLINK parameter that flags if ROCE is enabled. Fixes: fa69eaef5f49 ("common/mlx5: support ROCE disable through Netlink") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_nl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_nl.c b/drivers/common/mlx5/mlx5_nl.c index d9f0d4129e..c144223aad 100644 --- a/drivers/common/mlx5/mlx5_nl.c +++ b/drivers/common/mlx5/mlx5_nl.c @@ -1557,7 +1557,7 @@ mlx5_nl_enable_roce_get(int nlsk_fd, int family_id, const char *pci_addr, struct genlmsghdr *genl; uint32_t sn = MLX5_NL_SN_GENERATE; int ret; - int cur_en; + int cur_en = 0; uint8_t buf[NLMSG_ALIGN(sizeof(struct nlmsghdr)) + NLMSG_ALIGN(sizeof(struct genlmsghdr)) + NLMSG_ALIGN(sizeof(struct nlattr)) * 4 + -- 2.20.1