From 57d77c23baf822ca63148a7e5816e7eaad4802de Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Wed, 31 Oct 2018 19:43:51 +0100 Subject: [PATCH] add reminders in code --- libecoli/ecoli_log.c | 1 + libecoli/ecoli_parse.c | 1 + libecoli/ecoli_parse.h | 1 + 3 files changed, 3 insertions(+) diff --git a/libecoli/ecoli_log.c b/libecoli/ecoli_log.c index e7577cd..aefba83 100644 --- a/libecoli/ecoli_log.c +++ b/libecoli/ecoli_log.c @@ -95,6 +95,7 @@ ec_log_type_register(const char *name) if (id >= 0) return id; + // XXX not that good to allocate in constructor new_types = ec_realloc(log_types, sizeof(*new_types) * (log_types_len + 1)); if (new_types == NULL) diff --git a/libecoli/ecoli_parse.c b/libecoli/ecoli_parse.c index 917af3a..3d6be77 100644 --- a/libecoli/ecoli_parse.c +++ b/libecoli/ecoli_parse.c @@ -91,6 +91,7 @@ int ec_node_parse_child(const struct ec_node *node, struct ec_parse *state, return __ec_node_parse_child(node, state, false, strvec); } +// XXX what is returned if no match ?? struct ec_parse *ec_node_parse_strvec(const struct ec_node *node, const struct ec_strvec *strvec) { diff --git a/libecoli/ecoli_parse.h b/libecoli/ecoli_parse.h index 9d6d5d5..a431ba2 100644 --- a/libecoli/ecoli_parse.h +++ b/libecoli/ecoli_parse.h @@ -56,6 +56,7 @@ struct ec_parse *ec_parse_dup(const struct ec_parse *parse); * * */ +// _get_ XXX const struct ec_strvec *ec_parse_strvec(const struct ec_parse *parse); /* a NULL return value is an error, with errno set -- 2.20.1