X-Git-Url: http://git.droids-corp.org/?p=protos%2Fxbee-avr.git;a=blobdiff_plain;f=main.c;h=20d368b120764d8127447994ff16ba43b407c833;hp=c6f13e3715dee230db91032bf872529e68e1b394;hb=04735ee519979e772e94824304111369f6d01f2b;hpb=d590ebe19bfe60a544717606a0ff2b348cc32229

diff --git a/main.c b/main.c
index c6f13e3..20d368b 100644
--- a/main.c
+++ b/main.c
@@ -203,15 +203,16 @@ static int dump_atcmd(struct xbee_ctx *ctx, struct xbee_atresp_hdr *frame,
 	result = (void *)frame->data;
 	len -= offsetof(struct xbee_atresp_hdr, data);
 	if (cmd.flags & XBEE_ATCMD_F_PARAM_U8 && len == sizeof(uint8_t))
-		printf_P(PSTR("<%s> is 0x%x\r\n"), atcmd_str, result->u8);
+		printf_P(PSTR("<%s> is 0x%x (%d)\r\n"), atcmd_str, result->u8,
+			 result->u8);
 	else if (cmd.flags & XBEE_ATCMD_F_PARAM_U16 && len == sizeof(uint16_t))
-		printf_P(PSTR("<%s> is 0x%x\r\n"),
+		printf_P(PSTR("<%s> is 0x%x (%d)\r\n"),
 			 atcmd_str,
-			 ntohs(result->u16));
+			 ntohs(result->u16), ntohs(result->u16));
 	else if (cmd.flags & XBEE_ATCMD_F_PARAM_U32 && len == sizeof(uint32_t))
-		printf_P(PSTR("<%s> is 0x%"PRIx32"\r\n"),
+		printf_P(PSTR("<%s> is 0x%"PRIx32" (%"PRIu32")\r\n"),
 			 atcmd_str,
-			 ntohl(result->u32));
+			 ntohl(result->u32), ntohs(result->u32));
 	else if (cmd.flags & XBEE_ATCMD_F_PARAM_S16 && len == sizeof(int16_t))
 		printf_P(PSTR("<%s> is %d\r\n"), atcmd_str, ntohs(result->s16));
 	else if (len == 0)
@@ -273,11 +274,11 @@ int xbee_recv_data(struct xbee_recv_hdr *recvframe, unsigned len)
 }
 
 /* socat /dev/ttyUSB0,raw,echo=0,b115200 /dev/ttyACM1,raw,echo=0,b115200 */
-void xbeeapp_rx(struct xbee_dev *dev, int channel, int type,
+int8_t xbeeapp_rx(struct xbee_dev *dev, int channel, int type,
 	     void *frame, unsigned len, void *opaque)
 {
 	struct xbee_ctx *ctx = opaque;
-	int do_hexdump = xbee_hexdump;
+	int8_t ret = 0;
 
 	if (xbee_debug)
 		printf_P(PSTR("type=0x%x, channel=%d, ctx=%p\r\n"),
@@ -319,24 +320,28 @@ void xbeeapp_rx(struct xbee_dev *dev, int channel, int type,
 
 			/* this answer contains an atcmd answer at offset 10 */
 			if (dump_atcmd(ctx, frame + 10, len - 10) < 0)
-				do_hexdump = 1;
+				ret = -1;
+
 			break;
 		}
 		case XBEE_TYPE_ATRESP: {
 			if (dump_atcmd(ctx, frame, len) < 0)
-				do_hexdump = 1;
+				ret = -1;
+
 			break;
 		}
 
 		case XBEE_TYPE_XMIT_STATUS: {
 			if (parse_xmit_status(ctx, frame, len) < 0)
-				do_hexdump = 1;
+				ret = -1;
+
 			break;
 		}
 
 		case XBEE_TYPE_RECV: {
 			if (xbee_recv_data(frame, len) < 0)
-				do_hexdump = 1;
+				ret = -1;
+
 			break;
 		}
 
@@ -349,11 +354,13 @@ void xbeeapp_rx(struct xbee_dev *dev, int channel, int type,
 		case XBEE_TYPE_NODE_ID:
 		default:
 			printf_P(PSTR("Invalid frame\r\n"));
-			do_hexdump = 1;
+			ret = -1;
 			break;
 	}
 
-	if (do_hexdump)
+	if (ret < 0)
+		hexdump("undecoded rx frame", frame, len);
+	else if (xbee_hexdump)
 		hexdump("undecoded rx frame", frame, len);
 
 	/* restart command line if it was a blocking query */