1 /* SPDX-License-Identifier: BSD-3-Clause
2 * Copyright(c) 2017 Intel Corporation
5 #include <rte_common.h>
6 #include <rte_hexdump.h>
8 #include <rte_malloc.h>
9 #include <rte_memcpy.h>
10 #include <rte_cycles.h>
12 #include <rte_service.h>
13 #include <rte_service_component.h>
17 /* used as the service core ID */
18 static uint32_t slcore_id;
19 /* used as timestamp to detect if a service core is running */
20 static uint64_t service_tick;
21 /* used as a flag to check if a function was run */
22 static uint32_t service_remote_launch_flag;
24 #define SERVICE_DELAY 1
26 #define DUMMY_SERVICE_NAME "dummy_service"
27 #define MT_SAFE_SERVICE_NAME "mt_safe_service"
32 slcore_id = rte_get_next_lcore(/* start core */ -1,
40 testsuite_teardown(void)
42 /* release service cores? */
45 static int32_t dummy_cb(void *args)
49 rte_delay_ms(SERVICE_DELAY);
53 static int32_t dummy_mt_unsafe_cb(void *args)
55 /* before running test, the initialization has set pass_test to 1.
56 * If the cmpset in service-cores is working correctly, the code here
57 * should never fail to take the lock. If the lock *is* taken, fail the
58 * test, because two threads are concurrently in a non-MT safe callback.
60 uint32_t *test_params = args;
61 uint32_t *atomic_lock = &test_params[0];
62 uint32_t *pass_test = &test_params[1];
63 int lock_taken = rte_atomic32_cmpset(atomic_lock, 0, 1);
65 /* delay with the lock held */
67 rte_atomic32_clear((rte_atomic32_t *)atomic_lock);
69 /* 2nd thread will fail to take lock, so set pass flag */
77 static int32_t dummy_mt_safe_cb(void *args)
79 /* Atomic checks to ensure MT safe services allow > 1 thread to
80 * concurrently run the callback. The concept is as follows;
81 * 1) if lock is available, take the lock then delay
82 * 2) if first lock is taken, and a thread arrives in the CB, we know
83 * that 2 threads are running the callback at the same time: MT safe
85 uint32_t *test_params = args;
86 uint32_t *atomic_lock = &test_params[0];
87 uint32_t *pass_test = &test_params[1];
88 int lock_taken = rte_atomic32_cmpset(atomic_lock, 0, 1);
90 /* delay with the lock held */
92 rte_atomic32_clear((rte_atomic32_t *)atomic_lock);
94 /* 2nd thread will fail to take lock, so set pass flag */
101 /* unregister all services */
107 TEST_ASSERT_EQUAL(-EINVAL, rte_service_component_unregister(1000),
108 "Unregistered invalid service id");
110 uint32_t c = rte_service_get_count();
111 for (i = 0; i < c; i++) {
112 TEST_ASSERT_EQUAL(0, rte_service_component_unregister(i),
113 "Error unregistering a valid service");
116 rte_service_lcore_reset_all();
121 /* register a single dummy service */
125 /* make sure there are no remains from previous tests */
128 struct rte_service_spec service;
129 memset(&service, 0, sizeof(struct rte_service_spec));
131 TEST_ASSERT_EQUAL(-EINVAL,
132 rte_service_component_register(&service, NULL),
134 service.callback = dummy_cb;
136 TEST_ASSERT_EQUAL(-EINVAL,
137 rte_service_component_register(&service, NULL),
139 snprintf(service.name, sizeof(service.name), DUMMY_SERVICE_NAME);
142 TEST_ASSERT_EQUAL(0, rte_service_component_register(&service, &id),
143 "Failed to register valid service");
145 rte_service_component_runstate_set(id, 1);
150 /* verify get_by_name() service lookup */
152 service_get_by_name(void)
157 TEST_ASSERT_EQUAL(-ENODEV,
158 rte_service_get_by_name(DUMMY_SERVICE_NAME, &sid),
159 "get by name with invalid name should return -ENODEV");
160 TEST_ASSERT_EQUAL(-EINVAL,
161 rte_service_get_by_name(DUMMY_SERVICE_NAME, 0x0),
162 "get by name with NULL ptr should return -ENODEV");
164 /* register service */
165 struct rte_service_spec service;
166 memset(&service, 0, sizeof(struct rte_service_spec));
167 TEST_ASSERT_EQUAL(-EINVAL,
168 rte_service_component_register(&service, NULL),
170 service.callback = dummy_cb;
171 TEST_ASSERT_EQUAL(-EINVAL,
172 rte_service_component_register(&service, NULL),
174 snprintf(service.name, sizeof(service.name), DUMMY_SERVICE_NAME);
175 TEST_ASSERT_EQUAL(0, rte_service_component_register(&service, NULL),
176 "Failed to register valid service");
178 /* we unregistered all service, now registering 1, should be id 0 */
179 uint32_t service_id_as_expected = 0;
180 TEST_ASSERT_EQUAL(0, rte_service_get_by_name(DUMMY_SERVICE_NAME, &sid),
181 "Service get_by_name should return 0 on valid inputs");
182 TEST_ASSERT_EQUAL(service_id_as_expected, sid,
183 "Service get_by_name should equal expected id");
187 /* ensure after unregister, get_by_name returns NULL */
188 TEST_ASSERT_EQUAL(-ENODEV,
189 rte_service_get_by_name(DUMMY_SERVICE_NAME, &sid),
190 "get by name should return -ENODEV after unregister");
195 /* verify probe of capabilities */
197 service_probe_capability(void)
201 struct rte_service_spec service;
202 memset(&service, 0, sizeof(struct rte_service_spec));
203 service.callback = dummy_cb;
204 snprintf(service.name, sizeof(service.name), DUMMY_SERVICE_NAME);
205 service.capabilities |= RTE_SERVICE_CAP_MT_SAFE;
206 TEST_ASSERT_EQUAL(0, rte_service_component_register(&service, NULL),
207 "Register of MT SAFE service failed");
209 /* verify flag is enabled */
210 const uint32_t sid = 0;
211 int32_t mt = rte_service_probe_capability(sid, RTE_SERVICE_CAP_MT_SAFE);
212 TEST_ASSERT_EQUAL(1, mt, "MT SAFE capability flag not set.");
217 memset(&service, 0, sizeof(struct rte_service_spec));
218 service.callback = dummy_cb;
219 snprintf(service.name, sizeof(service.name), DUMMY_SERVICE_NAME);
220 TEST_ASSERT_EQUAL(0, rte_service_component_register(&service, NULL),
221 "Register of non-MT safe service failed");
223 /* verify flag is enabled */
224 mt = rte_service_probe_capability(sid, RTE_SERVICE_CAP_MT_SAFE);
225 TEST_ASSERT_EQUAL(0, mt, "MT SAFE cap flag set on non MT SAFE service");
227 return unregister_all();
230 /* verify the service name */
234 const char *name = rte_service_get_name(0);
235 int equal = strcmp(name, DUMMY_SERVICE_NAME);
236 TEST_ASSERT_EQUAL(0, equal, "Error: Service name not correct");
238 return unregister_all();
241 /* verify service dump */
245 const uint32_t sid = 0;
246 rte_service_set_stats_enable(sid, 1);
247 rte_service_dump(stdout, 0);
248 rte_service_set_stats_enable(sid, 0);
249 rte_service_dump(stdout, 0);
250 return unregister_all();
253 /* start and stop a service */
255 service_start_stop(void)
257 const uint32_t sid = 0;
259 /* runstate_get() returns if service is running and slcore is mapped */
260 TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_id),
261 "Service core add did not return zero");
262 int ret = rte_service_map_lcore_set(sid, slcore_id, 1);
263 TEST_ASSERT_EQUAL(0, ret,
264 "Enabling service core, expected 0 got %d", ret);
266 TEST_ASSERT_EQUAL(0, rte_service_runstate_get(sid),
267 "Error: Service should be stopped");
269 TEST_ASSERT_EQUAL(0, rte_service_runstate_set(sid, 0),
270 "Error: Service stopped returned non-zero");
272 TEST_ASSERT_EQUAL(0, rte_service_runstate_get(sid),
273 "Error: Service is running - should be stopped");
275 TEST_ASSERT_EQUAL(0, rte_service_runstate_set(sid, 1),
276 "Error: Service start returned non-zero");
278 TEST_ASSERT_EQUAL(1, rte_service_runstate_get(sid),
279 "Error: Service is not running");
281 return unregister_all();
286 service_remote_launch_func(void *arg)
289 service_remote_launch_flag = 1;
293 /* enable and disable a lcore for a service */
295 service_lcore_en_dis_able(void)
297 const uint32_t sid = 0;
299 /* expected failure cases */
300 TEST_ASSERT_EQUAL(-EINVAL, rte_service_map_lcore_set(sid, 100000, 1),
301 "Enable on invalid core did not fail");
302 TEST_ASSERT_EQUAL(-EINVAL, rte_service_map_lcore_set(sid, 100000, 0),
303 "Disable on invalid core did not fail");
305 /* add service core to allow enabling */
306 TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_id),
307 "Add service core failed when not in use before");
310 TEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(sid, slcore_id, 1),
311 "Enabling valid service and core failed");
312 TEST_ASSERT_EQUAL(1, rte_service_map_lcore_get(sid, slcore_id),
313 "Enabled core returned not-enabled");
316 TEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(sid, slcore_id, 0),
317 "Disabling valid service and lcore failed");
318 TEST_ASSERT_EQUAL(0, rte_service_map_lcore_get(sid, slcore_id),
319 "Disabled core returned enabled");
321 /* call remote_launch to verify that app can launch ex-service lcore */
322 service_remote_launch_flag = 0;
323 rte_eal_wait_lcore(slcore_id);
324 int ret = rte_eal_remote_launch(service_remote_launch_func, NULL,
326 TEST_ASSERT_EQUAL(0, ret, "Ex-service core remote launch failed.");
327 rte_eal_mp_wait_lcore();
328 TEST_ASSERT_EQUAL(1, service_remote_launch_flag,
329 "Ex-service core function call had no effect.");
331 return unregister_all();
335 service_lcore_running_check(void)
337 uint64_t tick = service_tick;
338 rte_delay_ms(SERVICE_DELAY * 100);
339 /* if (tick != service_tick) we know the lcore as polled the service */
340 return tick != service_tick;
344 service_lcore_add_del(void)
346 /* check initial count */
347 TEST_ASSERT_EQUAL(0, rte_service_lcore_count(),
348 "Service lcore count has value before adding a lcore");
350 /* check service lcore add */
351 TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_id),
352 "Add service core failed when not in use before");
353 TEST_ASSERT_EQUAL(-EALREADY, rte_service_lcore_add(slcore_id),
354 "Add service core failed to refuse in-use lcore");
357 TEST_ASSERT_EQUAL(1, rte_service_lcore_count(),
358 "Service core count not equal to one");
360 /* retrieve core list, checking lcore ids */
361 const uint32_t size = 4;
362 uint32_t service_core_ids[size];
363 int32_t n = rte_service_lcore_list(service_core_ids, size);
364 TEST_ASSERT_EQUAL(1, n, "Service core list return should equal 1");
365 TEST_ASSERT_EQUAL(slcore_id, service_core_ids[0],
366 "Service core list lcore must equal slcore_id");
368 /* recheck count, add more cores, and check count */
369 TEST_ASSERT_EQUAL(1, rte_service_lcore_count(),
370 "Service core count not equal to one");
371 uint32_t slcore_1 = rte_get_next_lcore(/* start core */ -1,
374 TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_1),
375 "Service core add did not return zero");
376 uint32_t slcore_2 = rte_get_next_lcore(/* start core */ slcore_1,
379 TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_2),
380 "Service core add did not return zero");
382 uint32_t count = rte_service_lcore_count();
383 const uint32_t cores_at_this_point = 3;
384 TEST_ASSERT_EQUAL(cores_at_this_point, count,
385 "Service core count %d, expected %d", count,
386 cores_at_this_point);
388 /* check longer service core list */
389 n = rte_service_lcore_list(service_core_ids, size);
390 TEST_ASSERT_EQUAL(3, n, "Service core list return should equal 3");
391 TEST_ASSERT_EQUAL(slcore_id, service_core_ids[0],
392 "Service core list[0] lcore must equal 1");
393 TEST_ASSERT_EQUAL(slcore_1, service_core_ids[1],
394 "Service core list[1] lcore must equal 2");
395 TEST_ASSERT_EQUAL(slcore_2, service_core_ids[2],
396 "Service core list[2] lcore must equal 3");
398 /* recheck count, remove lcores, check remaining lcore_id is correct */
399 TEST_ASSERT_EQUAL(3, rte_service_lcore_count(),
400 "Service core count not equal to three");
401 TEST_ASSERT_EQUAL(0, rte_service_lcore_del(slcore_1),
402 "Service core add did not return zero");
403 TEST_ASSERT_EQUAL(0, rte_service_lcore_del(slcore_2),
404 "Service core add did not return zero");
405 TEST_ASSERT_EQUAL(1, rte_service_lcore_count(),
406 "Service core count not equal to one");
407 n = rte_service_lcore_list(service_core_ids, size);
408 TEST_ASSERT_EQUAL(1, n, "Service core list return should equal one");
409 TEST_ASSERT_EQUAL(slcore_id, service_core_ids[0],
410 "Service core list[0] lcore must equal %d",
413 return unregister_all();
417 service_threaded_test(int mt_safe)
421 /* add next 2 cores */
422 uint32_t slcore_1 = rte_get_next_lcore(/* start core */ -1,
425 TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_1),
426 "mt safe lcore add fail");
427 uint32_t slcore_2 = rte_get_next_lcore(/* start core */ slcore_1,
430 TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_2),
431 "mt safe lcore add fail");
433 /* Use atomic locks to verify that two threads are in the same function
434 * at the same time. These are passed to the unit tests through the
435 * callback userdata parameter
437 uint32_t test_params[2];
438 memset(test_params, 0, sizeof(uint32_t) * 2);
440 /* register MT safe service. */
441 struct rte_service_spec service;
442 memset(&service, 0, sizeof(struct rte_service_spec));
443 service.callback_userdata = test_params;
444 snprintf(service.name, sizeof(service.name), MT_SAFE_SERVICE_NAME);
447 service.callback = dummy_mt_safe_cb;
448 service.capabilities |= RTE_SERVICE_CAP_MT_SAFE;
450 service.callback = dummy_mt_unsafe_cb;
453 TEST_ASSERT_EQUAL(0, rte_service_component_register(&service, &id),
454 "Register of MT SAFE service failed");
456 const uint32_t sid = 0;
457 TEST_ASSERT_EQUAL(0, rte_service_runstate_set(sid, 1),
458 "Starting valid service failed");
459 TEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(sid, slcore_1, 1),
460 "Failed to enable lcore 1 on mt safe service");
461 TEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(sid, slcore_2, 1),
462 "Failed to enable lcore 2 on mt safe service");
463 rte_service_lcore_start(slcore_1);
464 rte_service_lcore_start(slcore_2);
466 /* wait for the worker threads to run */
468 rte_service_lcore_stop(slcore_1);
469 rte_service_lcore_stop(slcore_2);
471 TEST_ASSERT_EQUAL(0, test_params[1],
472 "Service run with component runstate = 0");
474 /* enable backend runstate: the service should run after this */
475 rte_service_component_runstate_set(id, 1);
477 /* initialize to pass, see callback comment for details */
481 /* wait for lcores before start() */
482 rte_eal_wait_lcore(slcore_1);
483 rte_eal_wait_lcore(slcore_2);
485 rte_service_lcore_start(slcore_1);
486 rte_service_lcore_start(slcore_2);
488 /* wait for the worker threads to run */
490 rte_service_lcore_stop(slcore_1);
491 rte_service_lcore_stop(slcore_2);
493 TEST_ASSERT_EQUAL(1, test_params[1],
494 "MT Safe service not run by two cores concurrently");
495 TEST_ASSERT_EQUAL(0, rte_service_runstate_set(sid, 0),
496 "Failed to stop MT Safe service");
498 rte_eal_wait_lcore(slcore_1);
499 rte_eal_wait_lcore(slcore_2);
502 /* return the value of the callback pass_test variable to caller */
503 return test_params[1];
506 /* tests an MT SAFE service with two cores. The callback function ensures that
507 * two threads access the callback concurrently.
510 service_mt_safe_poll(void)
513 TEST_ASSERT_EQUAL(1, service_threaded_test(mt_safe),
514 "Error: MT Safe service not run by two cores concurrently");
518 /* tests a NON mt safe service with two cores, the callback is serialized
519 * using the atomic cmpset.
522 service_mt_unsafe_poll(void)
525 TEST_ASSERT_EQUAL(1, service_threaded_test(mt_safe),
526 "Error: NON MT Safe service run by two cores concurrently");
531 delay_as_a_mt_safe_service(void *args)
534 uint32_t *params = args;
536 /* retrieve done flag and atomic lock to inc/dec */
537 uint32_t *done = ¶ms[0];
538 rte_atomic32_t *lock = (rte_atomic32_t *)¶ms[1];
541 rte_atomic32_inc(lock);
543 if (rte_atomic32_read(lock) > 1)
544 /* pass: second core has simultaneously incremented */
546 rte_atomic32_dec(lock);
553 delay_as_a_service(void *args)
555 uint32_t *done = (uint32_t *)args;
562 service_run_on_app_core_func(void *arg)
564 uint32_t *delay_service_id = (uint32_t *)arg;
565 return rte_service_run_iter_on_app_lcore(*delay_service_id, 1);
569 service_app_lcore_poll_impl(const int mt_safe)
571 uint32_t params[2] = {0};
573 struct rte_service_spec service;
574 memset(&service, 0, sizeof(struct rte_service_spec));
575 snprintf(service.name, sizeof(service.name), MT_SAFE_SERVICE_NAME);
577 service.callback = delay_as_a_mt_safe_service;
578 service.callback_userdata = params;
579 service.capabilities |= RTE_SERVICE_CAP_MT_SAFE;
581 service.callback = delay_as_a_service;
582 service.callback_userdata = ¶ms;
586 TEST_ASSERT_EQUAL(0, rte_service_component_register(&service, &id),
587 "Register of app lcore delay service failed");
589 rte_service_component_runstate_set(id, 1);
590 rte_service_runstate_set(id, 1);
592 uint32_t app_core2 = rte_get_next_lcore(slcore_id, 1, 1);
593 rte_eal_wait_lcore(app_core2);
594 int app_core2_ret = rte_eal_remote_launch(service_run_on_app_core_func,
599 int app_core1_ret = service_run_on_app_core_func(&id);
601 /* flag done, then wait for the spawned 2nd core to return */
603 rte_eal_mp_wait_lcore();
605 /* core two gets launched first - and should hold the service lock */
606 TEST_ASSERT_EQUAL(0, app_core2_ret,
607 "App core2 : run service didn't return zero");
610 /* mt safe should have both cores return 0 for success */
611 TEST_ASSERT_EQUAL(0, app_core1_ret,
612 "MT Safe: App core1 didn't return 0");
614 /* core one attempts to run later - should be blocked */
615 TEST_ASSERT_EQUAL(-EBUSY, app_core1_ret,
616 "MT Unsafe: App core1 didn't return -EBUSY");
625 service_app_lcore_mt_safe(void)
627 const int mt_safe = 1;
628 return service_app_lcore_poll_impl(mt_safe);
632 service_app_lcore_mt_unsafe(void)
634 const int mt_safe = 0;
635 return service_app_lcore_poll_impl(mt_safe);
638 /* start and stop a service core - ensuring it goes back to sleep */
640 service_lcore_start_stop(void)
642 /* start service core and service, create mapping so tick() runs */
643 const uint32_t sid = 0;
644 TEST_ASSERT_EQUAL(0, rte_service_runstate_set(sid, 1),
645 "Starting valid service failed");
646 TEST_ASSERT_EQUAL(-EINVAL, rte_service_map_lcore_set(sid, slcore_id, 1),
647 "Enabling valid service on non-service core must fail");
650 TEST_ASSERT_EQUAL(-EINVAL, rte_service_lcore_start(slcore_id),
651 "Service core start without add should return EINVAL");
652 TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_id),
653 "Service core add did not return zero");
654 TEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(sid, slcore_id, 1),
655 "Enabling valid service on valid core failed");
656 TEST_ASSERT_EQUAL(0, rte_service_lcore_start(slcore_id),
657 "Service core start after add failed");
658 TEST_ASSERT_EQUAL(-EALREADY, rte_service_lcore_start(slcore_id),
659 "Service core expected as running but was stopped");
661 /* ensures core really is running the service function */
662 TEST_ASSERT_EQUAL(1, service_lcore_running_check(),
663 "Service core expected to poll service but it didn't");
666 TEST_ASSERT_EQUAL(-EBUSY, rte_service_lcore_stop(slcore_id),
667 "Service core running a service should return -EBUSY");
668 TEST_ASSERT_EQUAL(0, rte_service_runstate_set(sid, 0),
669 "Stopping valid service failed");
670 TEST_ASSERT_EQUAL(-EINVAL, rte_service_lcore_stop(100000),
671 "Invalid Service core stop should return -EINVAL");
672 TEST_ASSERT_EQUAL(0, rte_service_lcore_stop(slcore_id),
673 "Service core stop expected to return 0");
674 TEST_ASSERT_EQUAL(-EALREADY, rte_service_lcore_stop(slcore_id),
675 "Already stopped service core should return -EALREADY");
677 /* ensure service is not longer running */
678 TEST_ASSERT_EQUAL(0, service_lcore_running_check(),
679 "Service core expected to poll service but it didn't");
681 TEST_ASSERT_EQUAL(0, rte_service_lcore_del(slcore_id),
682 "Service core del did not return zero");
684 return unregister_all();
687 static struct unit_test_suite service_tests = {
688 .suite_name = "service core test suite",
689 .setup = testsuite_setup,
690 .teardown = testsuite_teardown,
692 TEST_CASE_ST(dummy_register, NULL, unregister_all),
693 TEST_CASE_ST(dummy_register, NULL, service_name),
694 TEST_CASE_ST(dummy_register, NULL, service_get_by_name),
695 TEST_CASE_ST(dummy_register, NULL, service_dump),
696 TEST_CASE_ST(dummy_register, NULL, service_probe_capability),
697 TEST_CASE_ST(dummy_register, NULL, service_start_stop),
698 TEST_CASE_ST(dummy_register, NULL, service_lcore_add_del),
699 TEST_CASE_ST(dummy_register, NULL, service_lcore_start_stop),
700 TEST_CASE_ST(dummy_register, NULL, service_lcore_en_dis_able),
701 TEST_CASE_ST(dummy_register, NULL, service_mt_unsafe_poll),
702 TEST_CASE_ST(dummy_register, NULL, service_mt_safe_poll),
703 TEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_safe),
704 TEST_CASE_ST(dummy_register, NULL, service_app_lcore_mt_unsafe),
705 TEST_CASES_END() /**< NULL terminate unit test array */
710 test_service_common(void)
712 return unit_test_suite_runner(&service_tests);
715 REGISTER_TEST_COMMAND(service_autotest, test_service_common);