fm10k: support Rx descriptor check
[dpdk.git] / drivers / net / fm10k / fm10k_ethdev.c
index 7fcebed..a28879a 100644 (file)
 #define CHARS_PER_UINT32 (sizeof(uint32_t))
 #define BIT_MASK_PER_UINT32 ((1 << CHARS_PER_UINT32) - 1)
 
+/* First 64 Logical ports for PF/VMDQ, second 64 for Flow director */
+#define MAX_LPORT_NUM    128
+#define GLORT_FD_Q_BASE  0x40
+#define GLORT_PF_MASK    0xFFC0
+#define GLORT_FD_MASK    GLORT_PF_MASK
+#define GLORT_FD_INDEX   GLORT_FD_Q_BASE
+
 static void fm10k_close_mbx_service(struct fm10k_hw *hw);
 static void fm10k_dev_promiscuous_enable(struct rte_eth_dev *dev);
 static void fm10k_dev_promiscuous_disable(struct rte_eth_dev *dev);
@@ -67,6 +74,48 @@ static void fm10k_MAC_filter_set(struct rte_eth_dev *dev,
        const u8 *mac, bool add, uint32_t pool);
 static void fm10k_tx_queue_release(void *queue);
 static void fm10k_rx_queue_release(void *queue);
+static void fm10k_set_rx_function(struct rte_eth_dev *dev);
+static void fm10k_set_tx_function(struct rte_eth_dev *dev);
+
+struct fm10k_xstats_name_off {
+       char name[RTE_ETH_XSTATS_NAME_SIZE];
+       unsigned offset;
+};
+
+struct fm10k_xstats_name_off fm10k_hw_stats_strings[] = {
+       {"completion_timeout_count", offsetof(struct fm10k_hw_stats, timeout)},
+       {"unsupported_requests_count", offsetof(struct fm10k_hw_stats, ur)},
+       {"completer_abort_count", offsetof(struct fm10k_hw_stats, ca)},
+       {"unsupported_message_count", offsetof(struct fm10k_hw_stats, um)},
+       {"checksum_error_count", offsetof(struct fm10k_hw_stats, xec)},
+       {"vlan_dropped", offsetof(struct fm10k_hw_stats, vlan_drop)},
+       {"loopback_dropped", offsetof(struct fm10k_hw_stats, loopback_drop)},
+       {"rx_mbuf_allocation_errors", offsetof(struct fm10k_hw_stats,
+               nodesc_drop)},
+};
+
+#define FM10K_NB_HW_XSTATS (sizeof(fm10k_hw_stats_strings) / \
+               sizeof(fm10k_hw_stats_strings[0]))
+
+struct fm10k_xstats_name_off fm10k_hw_stats_rx_q_strings[] = {
+       {"packets", offsetof(struct fm10k_hw_stats_q, rx_packets)},
+       {"bytes", offsetof(struct fm10k_hw_stats_q, rx_bytes)},
+       {"dropped", offsetof(struct fm10k_hw_stats_q, rx_drops)},
+};
+
+#define FM10K_NB_RX_Q_XSTATS (sizeof(fm10k_hw_stats_rx_q_strings) / \
+               sizeof(fm10k_hw_stats_rx_q_strings[0]))
+
+struct fm10k_xstats_name_off fm10k_hw_stats_tx_q_strings[] = {
+       {"packets", offsetof(struct fm10k_hw_stats_q, tx_packets)},
+       {"bytes", offsetof(struct fm10k_hw_stats_q, tx_bytes)},
+};
+
+#define FM10K_NB_TX_Q_XSTATS (sizeof(fm10k_hw_stats_tx_q_strings) / \
+               sizeof(fm10k_hw_stats_tx_q_strings[0]))
+
+#define FM10K_NB_XSTATS (FM10K_NB_HW_XSTATS + FM10K_MAX_QUEUES_PF * \
+               (FM10K_NB_RX_Q_XSTATS + FM10K_NB_TX_Q_XSTATS))
 
 static void
 fm10k_mbx_initlock(struct fm10k_hw *hw)
@@ -87,6 +136,65 @@ fm10k_mbx_unlock(struct fm10k_hw *hw)
        rte_spinlock_unlock(FM10K_DEV_PRIVATE_TO_MBXLOCK(hw->back));
 }
 
+/* Stubs needed for linkage when vPMD is disabled */
+int __attribute__((weak))
+fm10k_rx_vec_condition_check(__rte_unused struct rte_eth_dev *dev)
+{
+       return -1;
+}
+
+uint16_t __attribute__((weak))
+fm10k_recv_pkts_vec(
+       __rte_unused void *rx_queue,
+       __rte_unused struct rte_mbuf **rx_pkts,
+       __rte_unused uint16_t nb_pkts)
+{
+       return 0;
+}
+
+uint16_t __attribute__((weak))
+fm10k_recv_scattered_pkts_vec(
+               __rte_unused void *rx_queue,
+               __rte_unused struct rte_mbuf **rx_pkts,
+               __rte_unused uint16_t nb_pkts)
+{
+       return 0;
+}
+
+int __attribute__((weak))
+fm10k_rxq_vec_setup(__rte_unused struct fm10k_rx_queue *rxq)
+
+{
+       return -1;
+}
+
+void __attribute__((weak))
+fm10k_rx_queue_release_mbufs_vec(
+               __rte_unused struct fm10k_rx_queue *rxq)
+{
+       return;
+}
+
+void __attribute__((weak))
+fm10k_txq_vec_setup(__rte_unused struct fm10k_tx_queue *txq)
+{
+       return;
+}
+
+int __attribute__((weak))
+fm10k_tx_vec_condition_check(__rte_unused struct fm10k_tx_queue *txq)
+{
+       return -1;
+}
+
+uint16_t __attribute__((weak))
+fm10k_xmit_pkts_vec(__rte_unused void *tx_queue,
+               __rte_unused struct rte_mbuf **tx_pkts,
+               __rte_unused uint16_t nb_pkts)
+{
+       return 0;
+}
+
 /*
  * reset queue to initial state, allocate software buffers used when starting
  * device.
@@ -97,6 +205,7 @@ fm10k_mbx_unlock(struct fm10k_hw *hw)
 static inline int
 rx_queue_reset(struct fm10k_rx_queue *q)
 {
+       static const union fm10k_rx_desc zero = {{0} };
        uint64_t dma_addr;
        int i, diag;
        PMD_INIT_FUNC_TRACE();
@@ -117,6 +226,15 @@ rx_queue_reset(struct fm10k_rx_queue *q)
                q->hw_ring[i].q.hdr_addr = dma_addr;
        }
 
+       /* initialize extra software ring entries. Space for these extra
+        * entries is always allocated.
+        */
+       memset(&q->fake_mbuf, 0x0, sizeof(q->fake_mbuf));
+       for (i = 0; i < q->nb_fake_desc; ++i) {
+               q->sw_ring[q->nb_desc + i] = &q->fake_mbuf;
+               q->hw_ring[q->nb_desc + i] = zero;
+       }
+
        q->next_dd = 0;
        q->next_alloc = 0;
        q->next_trigger = q->alloc_thresh - 1;
@@ -142,6 +260,16 @@ rx_queue_clean(struct fm10k_rx_queue *q)
        for (i = 0; i < q->nb_desc; ++i)
                q->hw_ring[i] = zero;
 
+       /* zero faked descriptors */
+       for (i = 0; i < q->nb_fake_desc; ++i)
+               q->hw_ring[q->nb_desc + i] = zero;
+
+       /* vPMD driver has a different way of releasing mbufs. */
+       if (q->rx_using_sse) {
+               fm10k_rx_queue_release_mbufs_vec(q);
+               return;
+       }
+
        /* free software buffers */
        for (i = 0; i < q->nb_desc; ++i) {
                if (q->sw_ring[i]) {
@@ -320,6 +448,10 @@ fm10k_check_mq_mode(struct rte_eth_dev *dev)
        return 0;
 }
 
+static const struct fm10k_txq_ops def_txq_ops = {
+       .reset = tx_queue_reset,
+};
+
 static int
 fm10k_dev_configure(struct rte_eth_dev *dev)
 {
@@ -446,22 +578,11 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev)
 }
 
 static void
-fm10k_dev_logic_port_update(struct rte_eth_dev *dev,
-       uint16_t nb_lport_old, uint16_t nb_lport_new)
+fm10k_dev_logic_port_update(struct rte_eth_dev *dev, uint16_t nb_lport_new)
 {
        struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        uint32_t i;
 
-       fm10k_mbx_lock(hw);
-       /* Disable previous logic ports */
-       if (nb_lport_old)
-               hw->mac.ops.update_lport_state(hw, hw->mac.dglort_map,
-                       nb_lport_old, false);
-       /* Enable new logic ports */
-       hw->mac.ops.update_lport_state(hw, hw->mac.dglort_map,
-               nb_lport_new, true);
-       fm10k_mbx_unlock(hw);
-
        for (i = 0; i < nb_lport_new; i++) {
                /* Set unicast mode by default. App can change
                 * to other mode in other API func.
@@ -481,7 +602,7 @@ fm10k_dev_mq_rx_configure(struct rte_eth_dev *dev)
        struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
        struct fm10k_macvlan_filter_info *macvlan;
        uint16_t nb_queue_pools = 0; /* pool number in configuration */
-       uint16_t nb_lport_new, nb_lport_old;
+       uint16_t nb_lport_new;
 
        macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
        vmdq_conf = &dev->data->dev_conf.rx_adv_conf.vmdq_rx_conf;
@@ -499,9 +620,8 @@ fm10k_dev_mq_rx_configure(struct rte_eth_dev *dev)
        if (macvlan->nb_queue_pools == nb_queue_pools)
                return;
 
-       nb_lport_old = macvlan->nb_queue_pools ? macvlan->nb_queue_pools : 1;
        nb_lport_new = nb_queue_pools ? nb_queue_pools : 1;
-       fm10k_dev_logic_port_update(dev, nb_lport_old, nb_lport_new);
+       fm10k_dev_logic_port_update(dev, nb_lport_new);
 
        /* reset MAC/VLAN as it's based on VMDQ or PF main VSI */
        memset(dev->data->mac_addrs, 0,
@@ -551,6 +671,10 @@ fm10k_dev_tx_init(struct rte_eth_dev *dev)
                                base_addr >> (CHAR_BIT * sizeof(uint32_t)));
                FM10K_WRITE_REG(hw, FM10K_TDLEN(i), size);
        }
+
+       /* set up vector or scalar TX function as appropriate */
+       fm10k_set_tx_function(dev);
+
        return 0;
 }
 
@@ -611,7 +735,6 @@ fm10k_dev_rx_init(struct rte_eth_dev *dev)
                        dev->data->dev_conf.rxmode.enable_scatter) {
                        uint32_t reg;
                        dev->data->scattered_rx = 1;
-                       dev->rx_pkt_burst = fm10k_recv_scattered_pkts;
                        reg = FM10K_READ_REG(hw, FM10K_SRRCTL(i));
                        reg |= FM10K_SRRCTL_BUFFER_CHAINING_EN;
                        FM10K_WRITE_REG(hw, FM10K_SRRCTL(i), reg);
@@ -627,6 +750,10 @@ fm10k_dev_rx_init(struct rte_eth_dev *dev)
 
        /* Configure VMDQ/RSS if applicable */
        fm10k_dev_mq_rx_configure(dev);
+
+       /* Decide the best RX function */
+       fm10k_set_rx_function(dev);
+
        return 0;
 }
 
@@ -676,6 +803,7 @@ fm10k_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
                 */
                FM10K_WRITE_REG(hw, FM10K_RDH(rx_queue_id), 0);
                FM10K_WRITE_REG(hw, FM10K_RDT(rx_queue_id), rxq->nb_desc - 1);
+               dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
        }
 
        return err;
@@ -694,6 +822,7 @@ fm10k_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 
                /* Free mbuf and clean HW ring */
                rx_queue_clean(dev->data->rx_queues[rx_queue_id]);
+               dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;
        }
 
        return 0;
@@ -711,7 +840,9 @@ fm10k_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
        PMD_INIT_FUNC_TRACE();
 
        if (tx_queue_id < dev->data->nb_tx_queues) {
-               tx_queue_reset(dev->data->tx_queues[tx_queue_id]);
+               struct fm10k_tx_queue *q = dev->data->tx_queues[tx_queue_id];
+
+               q->ops->reset(q);
 
                /* reset head and tail pointers */
                FM10K_WRITE_REG(hw, FM10K_TDH(tx_queue_id), 0);
@@ -721,6 +852,7 @@ fm10k_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
                FM10K_WRITE_REG(hw, FM10K_TXDCTL(tx_queue_id),
                                        FM10K_TXDCTL_ENABLE | txdctl);
                FM10K_WRITE_FLUSH(hw);
+               dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
        } else
                err = -1;
 
@@ -737,6 +869,7 @@ fm10k_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)
        if (tx_queue_id < dev->data->nb_tx_queues) {
                tx_queue_disable(hw, tx_queue_id);
                tx_queue_clean(dev->data->tx_queues[tx_queue_id]);
+               dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;
        }
 
        return 0;
@@ -859,7 +992,7 @@ static void
 fm10k_dev_dglort_map_configure(struct rte_eth_dev *dev)
 {
        struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       uint32_t dglortdec, pool_len, rss_len, i;
+       uint32_t dglortdec, pool_len, rss_len, i, dglortmask;
        uint16_t nb_queue_pools;
        struct fm10k_macvlan_filter_info *macvlan;
 
@@ -867,16 +1000,24 @@ fm10k_dev_dglort_map_configure(struct rte_eth_dev *dev)
        nb_queue_pools = macvlan->nb_queue_pools;
        pool_len = nb_queue_pools ? fls(nb_queue_pools - 1) : 0;
        rss_len = fls(dev->data->nb_rx_queues - 1) - pool_len;
-       dglortdec = (rss_len << FM10K_DGLORTDEC_RSSLENGTH_SHIFT) | pool_len;
-
-       /* Establish only MAP 0 as valid */
-       FM10K_WRITE_REG(hw, FM10K_DGLORTMAP(0), FM10K_DGLORTMAP_ANY);
 
+       /* GLORT 0x0-0x3F are used by PF and VMDQ,  0x40-0x7F used by FD */
+       dglortdec = (rss_len << FM10K_DGLORTDEC_RSSLENGTH_SHIFT) | pool_len;
+       dglortmask = (GLORT_PF_MASK << FM10K_DGLORTMAP_MASK_SHIFT) |
+                       hw->mac.dglort_map;
+       FM10K_WRITE_REG(hw, FM10K_DGLORTMAP(0), dglortmask);
        /* Configure VMDQ/RSS DGlort Decoder */
        FM10K_WRITE_REG(hw, FM10K_DGLORTDEC(0), dglortdec);
 
+       /* Flow Director configurations, only queue number is valid. */
+       dglortdec = fls(dev->data->nb_rx_queues - 1);
+       dglortmask = (GLORT_FD_MASK << FM10K_DGLORTMAP_MASK_SHIFT) |
+                       (hw->mac.dglort_map + GLORT_FD_Q_BASE);
+       FM10K_WRITE_REG(hw, FM10K_DGLORTMAP(1), dglortmask);
+       FM10K_WRITE_REG(hw, FM10K_DGLORTDEC(1), dglortdec);
+
        /* Invalidate all other GLORT entries */
-       for (i = 1; i < FM10K_DGLORT_COUNT; i++)
+       for (i = 2; i < FM10K_DGLORT_COUNT; i++)
                FM10K_WRITE_REG(hw, FM10K_DGLORTMAP(i),
                                FM10K_DGLORTMAP_NONE);
 }
@@ -987,8 +1128,11 @@ fm10k_dev_queue_release(struct rte_eth_dev *dev)
        PMD_INIT_FUNC_TRACE();
 
        if (dev->data->tx_queues) {
-               for (i = 0; i < dev->data->nb_tx_queues; i++)
-                       fm10k_tx_queue_release(dev->data->tx_queues[i]);
+               for (i = 0; i < dev->data->nb_tx_queues; i++) {
+                       struct fm10k_tx_queue *txq = dev->data->tx_queues[i];
+
+                       tx_queue_free(txq);
+               }
        }
 
        if (dev->data->rx_queues) {
@@ -1001,16 +1145,12 @@ static void
 fm10k_dev_close(struct rte_eth_dev *dev)
 {
        struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       uint16_t nb_lport;
-       struct fm10k_macvlan_filter_info *macvlan;
 
        PMD_INIT_FUNC_TRACE();
 
-       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
-       nb_lport = macvlan->nb_queue_pools ? macvlan->nb_queue_pools : 1;
        fm10k_mbx_lock(hw);
        hw->mac.ops.update_lport_state(hw, hw->mac.dglort_map,
-               nb_lport, false);
+               MAX_LPORT_NUM, false);
        fm10k_mbx_unlock(hw);
 
        /* Stop mailbox service first */
@@ -1036,6 +1176,51 @@ fm10k_link_update(struct rte_eth_dev *dev,
        return 0;
 }
 
+static int
+fm10k_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,
+                unsigned n)
+{
+       struct fm10k_hw_stats *hw_stats =
+               FM10K_DEV_PRIVATE_TO_STATS(dev->data->dev_private);
+       unsigned i, q, count = 0;
+
+       if (n < FM10K_NB_XSTATS)
+               return FM10K_NB_XSTATS;
+
+       /* Global stats */
+       for (i = 0; i < FM10K_NB_HW_XSTATS; i++) {
+               snprintf(xstats[count].name, sizeof(xstats[count].name),
+                        "%s", fm10k_hw_stats_strings[count].name);
+               xstats[count].value = *(uint64_t *)(((char *)hw_stats) +
+                       fm10k_hw_stats_strings[count].offset);
+               count++;
+       }
+
+       /* PF queue stats */
+       for (q = 0; q < FM10K_MAX_QUEUES_PF; q++) {
+               for (i = 0; i < FM10K_NB_RX_Q_XSTATS; i++) {
+                       snprintf(xstats[count].name, sizeof(xstats[count].name),
+                                "rx_q%u_%s", q,
+                                fm10k_hw_stats_rx_q_strings[i].name);
+                       xstats[count].value =
+                               *(uint64_t *)(((char *)&hw_stats->q[q]) +
+                               fm10k_hw_stats_rx_q_strings[i].offset);
+                       count++;
+               }
+               for (i = 0; i < FM10K_NB_TX_Q_XSTATS; i++) {
+                       snprintf(xstats[count].name, sizeof(xstats[count].name),
+                                "tx_q%u_%s", q,
+                                fm10k_hw_stats_tx_q_strings[i].name);
+                       xstats[count].value =
+                               *(uint64_t *)(((char *)&hw_stats->q[q]) +
+                               fm10k_hw_stats_tx_q_strings[i].offset);
+                       count++;
+               }
+       }
+
+       return FM10K_NB_XSTATS;
+}
+
 static void
 fm10k_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
@@ -1133,8 +1318,7 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
                },
                .tx_free_thresh = FM10K_TX_FREE_THRESH_DEFAULT(0),
                .tx_rs_thresh = FM10K_TX_RS_THRESH_DEFAULT(0),
-               .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
-                               ETH_TXQ_FLAGS_NOOFFLOADS,
+               .txq_flags = FM10K_SIMPLE_TX_FLAG,
        };
 
        dev_info->rx_desc_lim = (struct rte_eth_desc_lim) {
@@ -1165,12 +1349,12 @@ fm10k_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
 
        if (macvlan->nb_queue_pools > 0) { /* VMDQ mode */
                PMD_INIT_LOG(ERR, "Cannot change VLAN filter in VMDQ mode");
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        if (vlan_id > ETH_VLAN_ID_MAX) {
                PMD_INIT_LOG(ERR, "Invalid vlan_id: must be < 4096");
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        vid_idx = FM10K_VFTA_IDX(vlan_id);
@@ -1182,7 +1366,7 @@ fm10k_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
        if (!on && !(macvlan->vfta[vid_idx] & vid_bit)) {
                PMD_INIT_LOG(ERR, "Invalid vlan_id: not existing "
                        "in the VLAN filter table");
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        fm10k_mbx_lock(hw);
@@ -1190,7 +1374,7 @@ fm10k_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
        fm10k_mbx_unlock(hw);
        if (result != FM10K_SUCCESS) {
                PMD_INIT_LOG(ERR, "VLAN update failed: %d", result);
-               return (-EIO);
+               return -EIO;
        }
 
        for (mac_index = 0; (mac_index < FM10K_MAX_MACADDR_NUM) &&
@@ -1211,7 +1395,7 @@ fm10k_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
        }
        if (result != FM10K_SUCCESS) {
                PMD_INIT_LOG(ERR, "MAC address update failed: %d", result);
-               return (-EIO);
+               return -EIO;
        }
 
        if (on) {
@@ -1362,34 +1546,6 @@ check_nb_desc(uint16_t min, uint16_t max, uint16_t mult, uint16_t request)
                return 0;
 }
 
-/*
- * Create a memzone for hardware descriptor rings. Malloc cannot be used since
- * the physical address is required. If the memzone is already created, then
- * this function returns a pointer to the existing memzone.
- */
-static inline const struct rte_memzone *
-allocate_hw_ring(const char *driver_name, const char *ring_name,
-       uint8_t port_id, uint16_t queue_id, int socket_id,
-       uint32_t size, uint32_t align)
-{
-       char name[RTE_MEMZONE_NAMESIZE];
-       const struct rte_memzone *mz;
-
-       snprintf(name, sizeof(name), "%s_%s_%d_%d_%d",
-                driver_name, ring_name, port_id, queue_id, socket_id);
-
-       /* return the memzone if it already exists */
-       mz = rte_memzone_lookup(name);
-       if (mz)
-               return mz;
-
-#ifdef RTE_LIBRTE_XEN_DOM0
-       return rte_memzone_reserve_bounded(name, size, socket_id, 0, align,
-                                          RTE_PGSIZE_2M);
-#else
-       return rte_memzone_reserve_aligned(name, size, socket_id, 0, align);
-#endif
-}
 
 static inline int
 check_thresh(uint16_t min, uint16_t max, uint16_t div, uint16_t request)
@@ -1422,7 +1578,7 @@ handle_rxconf(struct fm10k_rx_queue *q, const struct rte_eth_rxconf *conf)
                        rx_free_thresh, FM10K_RX_FREE_THRESH_MAX(q),
                        FM10K_RX_FREE_THRESH_MIN(q),
                        FM10K_RX_FREE_THRESH_DIV(q));
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        q->alloc_thresh = rx_free_thresh;
@@ -1478,7 +1634,7 @@ fm10k_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
        /* make sure the mempool element size can account for alignment. */
        if (!mempool_element_size_valid(mp)) {
                PMD_INIT_LOG(ERR, "Error : Mempool element size is too small");
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        /* make sure a valid number of descriptors have been requested */
@@ -1490,7 +1646,7 @@ fm10k_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
                        "and a multiple of %u",
                        nb_desc, (uint32_t)FM10K_MAX_RX_DESC, FM10K_MIN_RX_DESC,
                        FM10K_MULT_RX_DESC);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        /*
@@ -1508,27 +1664,28 @@ fm10k_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
                                socket_id);
        if (q == NULL) {
                PMD_INIT_LOG(ERR, "Cannot allocate queue structure");
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        /* setup queue */
        q->mp = mp;
        q->nb_desc = nb_desc;
+       q->nb_fake_desc = FM10K_MULT_RX_DESC;
        q->port_id = dev->data->port_id;
        q->queue_id = queue_id;
        q->tail_ptr = (volatile uint32_t *)
                &((uint32_t *)hw->hw_addr)[FM10K_RDT(queue_id)];
        if (handle_rxconf(q, conf))
-               return (-EINVAL);
+               return -EINVAL;
 
        /* allocate memory for the software ring */
        q->sw_ring = rte_zmalloc_socket("fm10k sw ring",
-                                       nb_desc * sizeof(struct rte_mbuf *),
-                                       RTE_CACHE_LINE_SIZE, socket_id);
+                       (nb_desc + q->nb_fake_desc) * sizeof(struct rte_mbuf *),
+                       RTE_CACHE_LINE_SIZE, socket_id);
        if (q->sw_ring == NULL) {
                PMD_INIT_LOG(ERR, "Cannot allocate software ring");
                rte_free(q);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        /*
@@ -1536,21 +1693,17 @@ fm10k_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
         * enough to hold the maximum ring size is requested to allow for
         * resizing in later calls to the queue setup function.
         */
-       mz = allocate_hw_ring(dev->driver->pci_drv.name, "rx_ring",
-                               dev->data->port_id, queue_id, socket_id,
-                               FM10K_MAX_RX_RING_SZ, FM10K_ALIGN_RX_DESC);
+       mz = rte_eth_dma_zone_reserve(dev, "rx_ring", queue_id,
+                                     FM10K_MAX_RX_RING_SZ, FM10K_ALIGN_RX_DESC,
+                                     socket_id);
        if (mz == NULL) {
                PMD_INIT_LOG(ERR, "Cannot allocate hardware ring");
                rte_free(q->sw_ring);
                rte_free(q);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
        q->hw_ring = mz->addr;
-#ifdef RTE_LIBRTE_XEN_DOM0
        q->hw_ring_phys_addr = rte_mem_phy2mch(mz->memseg_id, mz->phys_addr);
-#else
-       q->hw_ring_phys_addr = mz->phys_addr;
-#endif
 
        /* Check if number of descs satisfied Vector requirement */
        if (!rte_is_power_of_2(nb_desc)) {
@@ -1599,7 +1752,7 @@ handle_txconf(struct fm10k_tx_queue *q, const struct rte_eth_txconf *conf)
                        tx_free_thresh, FM10K_TX_FREE_THRESH_MAX(q),
                        FM10K_TX_FREE_THRESH_MIN(q),
                        FM10K_TX_FREE_THRESH_DIV(q));
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        q->free_thresh = tx_free_thresh;
@@ -1623,7 +1776,7 @@ handle_txconf(struct fm10k_tx_queue *q, const struct rte_eth_txconf *conf)
                        tx_rs_thresh, FM10K_TX_RS_THRESH_MAX(q),
                        FM10K_TX_RS_THRESH_MIN(q),
                        FM10K_TX_RS_THRESH_DIV(q));
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        q->rs_thresh = tx_rs_thresh;
@@ -1651,7 +1804,7 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
                        "and a multiple of %u",
                        nb_desc, (uint32_t)FM10K_MAX_TX_DESC, FM10K_MIN_TX_DESC,
                        FM10K_MULT_TX_DESC);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        /*
@@ -1660,7 +1813,9 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
         * different socket than was previously used.
         */
        if (dev->data->tx_queues[queue_id] != NULL) {
-               tx_queue_free(dev->data->tx_queues[queue_id]);
+               struct fm10k_tx_queue *txq = dev->data->tx_queues[queue_id];
+
+               tx_queue_free(txq);
                dev->data->tx_queues[queue_id] = NULL;
        }
 
@@ -1669,17 +1824,19 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
                                socket_id);
        if (q == NULL) {
                PMD_INIT_LOG(ERR, "Cannot allocate queue structure");
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        /* setup queue */
        q->nb_desc = nb_desc;
        q->port_id = dev->data->port_id;
        q->queue_id = queue_id;
+       q->txq_flags = conf->txq_flags;
+       q->ops = &def_txq_ops;
        q->tail_ptr = (volatile uint32_t *)
                &((uint32_t *)hw->hw_addr)[FM10K_TDT(queue_id)];
        if (handle_txconf(q, conf))
-               return (-EINVAL);
+               return -EINVAL;
 
        /* allocate memory for the software ring */
        q->sw_ring = rte_zmalloc_socket("fm10k sw ring",
@@ -1688,7 +1845,7 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
        if (q->sw_ring == NULL) {
                PMD_INIT_LOG(ERR, "Cannot allocate software ring");
                rte_free(q);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        /*
@@ -1696,21 +1853,17 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
         * enough to hold the maximum ring size is requested to allow for
         * resizing in later calls to the queue setup function.
         */
-       mz = allocate_hw_ring(dev->driver->pci_drv.name, "tx_ring",
-                               dev->data->port_id, queue_id, socket_id,
-                               FM10K_MAX_TX_RING_SZ, FM10K_ALIGN_TX_DESC);
+       mz = rte_eth_dma_zone_reserve(dev, "tx_ring", queue_id,
+                                     FM10K_MAX_TX_RING_SZ, FM10K_ALIGN_TX_DESC,
+                                     socket_id);
        if (mz == NULL) {
                PMD_INIT_LOG(ERR, "Cannot allocate hardware ring");
                rte_free(q->sw_ring);
                rte_free(q);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
        q->hw_ring = mz->addr;
-#ifdef RTE_LIBRTE_XEN_DOM0
        q->hw_ring_phys_addr = rte_mem_phy2mch(mz->memseg_id, mz->phys_addr);
-#else
-       q->hw_ring_phys_addr = mz->phys_addr;
-#endif
 
        /*
         * allocate memory for the RS bit tracker. Enough slots to hold the
@@ -1724,7 +1877,7 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
                PMD_INIT_LOG(ERR, "Cannot allocate RS bit tracker");
                rte_free(q->sw_ring);
                rte_free(q);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        dev->data->tx_queues[queue_id] = q;
@@ -1734,9 +1887,10 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,
 static void
 fm10k_tx_queue_release(void *queue)
 {
+       struct fm10k_tx_queue *q = queue;
        PMD_INIT_FUNC_TRACE();
 
-       tx_queue_free(queue);
+       tx_queue_free(q);
 }
 
 static int
@@ -2263,7 +2417,9 @@ static const struct eth_dev_ops fm10k_eth_dev_ops = {
        .allmulticast_enable    = fm10k_dev_allmulticast_enable,
        .allmulticast_disable   = fm10k_dev_allmulticast_disable,
        .stats_get              = fm10k_stats_get,
+       .xstats_get             = fm10k_xstats_get,
        .stats_reset            = fm10k_stats_reset,
+       .xstats_reset           = fm10k_stats_reset,
        .link_update            = fm10k_link_update,
        .dev_infos_get          = fm10k_dev_infos_get,
        .vlan_filter_set        = fm10k_vlan_filter_set,
@@ -2278,12 +2434,77 @@ static const struct eth_dev_ops fm10k_eth_dev_ops = {
        .rx_queue_release       = fm10k_rx_queue_release,
        .tx_queue_setup         = fm10k_tx_queue_setup,
        .tx_queue_release       = fm10k_tx_queue_release,
+       .rx_descriptor_done     = fm10k_dev_rx_descriptor_done,
        .reta_update            = fm10k_reta_update,
        .reta_query             = fm10k_reta_query,
        .rss_hash_update        = fm10k_rss_hash_update,
        .rss_hash_conf_get      = fm10k_rss_hash_conf_get,
 };
 
+static void __attribute__((cold))
+fm10k_set_tx_function(struct rte_eth_dev *dev)
+{
+       struct fm10k_tx_queue *txq;
+       int i;
+       int use_sse = 1;
+
+       for (i = 0; i < dev->data->nb_tx_queues; i++) {
+               txq = dev->data->tx_queues[i];
+               /* Check if Vector Tx is satisfied */
+               if (fm10k_tx_vec_condition_check(txq)) {
+                       use_sse = 0;
+                       break;
+               }
+       }
+
+       if (use_sse) {
+               PMD_INIT_LOG(DEBUG, "Use vector Tx func");
+               for (i = 0; i < dev->data->nb_tx_queues; i++) {
+                       txq = dev->data->tx_queues[i];
+                       fm10k_txq_vec_setup(txq);
+               }
+               dev->tx_pkt_burst = fm10k_xmit_pkts_vec;
+       } else {
+               dev->tx_pkt_burst = fm10k_xmit_pkts;
+               PMD_INIT_LOG(DEBUG, "Use regular Tx func");
+       }
+}
+
+static void __attribute__((cold))
+fm10k_set_rx_function(struct rte_eth_dev *dev)
+{
+       struct fm10k_dev_info *dev_info = FM10K_DEV_PRIVATE_TO_INFO(dev);
+       uint16_t i, rx_using_sse;
+
+       /* In order to allow Vector Rx there are a few configuration
+        * conditions to be met.
+        */
+       if (!fm10k_rx_vec_condition_check(dev) && dev_info->rx_vec_allowed) {
+               if (dev->data->scattered_rx)
+                       dev->rx_pkt_burst = fm10k_recv_scattered_pkts_vec;
+               else
+                       dev->rx_pkt_burst = fm10k_recv_pkts_vec;
+       } else if (dev->data->scattered_rx)
+               dev->rx_pkt_burst = fm10k_recv_scattered_pkts;
+       else
+               dev->rx_pkt_burst = fm10k_recv_pkts;
+
+       rx_using_sse =
+               (dev->rx_pkt_burst == fm10k_recv_scattered_pkts_vec ||
+               dev->rx_pkt_burst == fm10k_recv_pkts_vec);
+
+       if (rx_using_sse)
+               PMD_INIT_LOG(DEBUG, "Use vector Rx func");
+       else
+               PMD_INIT_LOG(DEBUG, "Use regular Rx func");
+
+       for (i = 0; i < dev->data->nb_rx_queues; i++) {
+               struct fm10k_rx_queue *rxq = dev->data->rx_queues[i];
+
+               rxq->rx_using_sse = rx_using_sse;
+       }
+}
+
 static void
 fm10k_params_init(struct rte_eth_dev *dev)
 {
@@ -2318,13 +2539,12 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)
        dev->rx_pkt_burst = &fm10k_recv_pkts;
        dev->tx_pkt_burst = &fm10k_xmit_pkts;
 
-       if (dev->data->scattered_rx)
-               dev->rx_pkt_burst = &fm10k_recv_scattered_pkts;
-
        /* only initialize in the primary process */
        if (rte_eal_process_type() != RTE_PROC_PRIMARY)
                return 0;
 
+       rte_eth_copy_pci_info(dev, dev->pci_dev);
+
        macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
        memset(macvlan, 0, sizeof(*macvlan));
        /* Vendor and Device ID need to be set before init of shared code */
@@ -2451,7 +2671,8 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)
         */
        fm10k_mbx_lock(hw);
        /* Enable port first */
-       hw->mac.ops.update_lport_state(hw, hw->mac.dglort_map, 1, 1);
+       hw->mac.ops.update_lport_state(hw, hw->mac.dglort_map,
+                                       MAX_LPORT_NUM, 1);
 
        /* Set unicast mode by default. App can change to other mode in other
         * API func.